From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934562AbbLRIlg (ORCPT ); Fri, 18 Dec 2015 03:41:36 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:45034 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbbLRIlf (ORCPT ); Fri, 18 Dec 2015 03:41:35 -0500 Message-ID: <5673C6A1.2090109@huawei.com> Date: Fri, 18 Dec 2015 16:41:05 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jiri Olsa CC: , , , , Jiri Olsa Subject: Re: [PATCH] tools build: Remove FEATURE-DUMP References: <566561BA.30909@huawei.com> <1449485338-62100-1-git-send-email-wangnan0@huawei.com> <20151207135254.GC26191@krava.brq.redhat.com> In-Reply-To: <20151207135254.GC26191@krava.brq.redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.5673C6B2.008D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e479da0c7f7acc3c0bf8cbc055b18f29 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/12/7 21:52, Jiri Olsa wrote: > On Mon, Dec 07, 2015 at 10:48:58AM +0000, Wang Nan wrote: >> Jiri introduces a FEATURE-INCLUDE file for feature checking. It >> contains same information with FEATURE-DUMP, so we can avoid generating >> FEATURE-DUMP. >> >> Following modification should ensure FEATURE_TESTS contains >> FEATURE_DISPLAY. >> >> Signed-off-by: Wang Nan >> Cc: Jiri Olsa >> --- >> >> I haven't thoroughly tested this patch, just want to show the >> possibility of removing FEATURE-DUMP. I don't insist on this. Jiri, if >> you find this patch is not good please simply ignore it. >> >> Thank you. >> >> --- >> >> tools/build/Makefile.feature | 8 +++----- >> tools/lib/bpf/.gitignore | 1 - >> tools/lib/bpf/Makefile | 2 +- >> tools/perf/.gitignore | 1 - >> tools/perf/Makefile.perf | 2 +- >> 5 files changed, 5 insertions(+), 9 deletions(-) >> >> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature >> index 51f8d59..98a13bd 100644 >> --- a/tools/build/Makefile.feature >> +++ b/tools/build/Makefile.feature >> @@ -123,10 +123,6 @@ define feature_print_text_code >> MSG = $(shell printf '...%30s: %s' $(1) $(2)) >> endef >> >> -FEATURE_DUMP_FILENAME = $(OUTPUT)FEATURE-DUMP$(FEATURE_USER) >> -FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)($(feature-$(feat)))) >> -FEATURE_DUMP_FILE := $(shell touch $(FEATURE_DUMP_FILENAME); cat $(FEATURE_DUMP_FILENAME)) >> - >> ifeq ($(dwarf-post-unwind),1) >> FEATURE_DUMP += dwarf-post-unwind($(dwarf-post-unwind-text)) >> endif >> @@ -141,6 +137,9 @@ endif >> # features detection state. >> FEATURE_INCLUDE_FILENAME = $(OUTPUT)FEATURE-INCLUDE$(FEATURE_USER) >> >> +FEATURE_DUMP := $(foreach feat,$(FEATURE_DISPLAY),feature-$(feat)=$(feature-$(feat))) >> +FEATURE_DUMP_FILE := $(foreach feat,$(FEATURE_DISPLAY),$(shell touch $(FEATURE_INCLUDE_FILENAME); cat $(FEATURE_INCLUDE_FILENAME) | grep 'feature-$(feat)=')) > hum, this ignores dwarf-post-unwind setup, I think it needs more changes > I'll post new version Hi Jiri, What the current status of this patch and 'tools build: Introduce features dump include makefile'? They are in my local tree for a long time. Thank you.