From: Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp>
To: Donavan Lance <tusklahoma@gmail.com>, Bastien Nocera <hadess@hadess.net>
Cc: jikos@kernel.org,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers
Date: Fri, 18 Dec 2015 18:12:36 +0900 [thread overview]
Message-ID: <5673CE04.90705@stu.hosei.ac.jp> (raw)
In-Reply-To: <5673A785.6000306@stu.hosei.ac.jp>
The "Charm" keys seem to issue short-cut key combinations.
I also found Microsoft's document by searching for the combinations.
https://msdn.microsoft.com/en-us/library/windows/hardware/dn614461(v=vs.85).aspx
So the behavior of hid-multitouch is completely fine.
On 12/18/2015 03:28 PM, Akihiko Odaki wrote:
>> The search, share, connect(?), and settings keys
> I tested the patch again with xev and found that those "charm"
> keys don't respond both on hid-microsoft and hid-multitouch, while
> other keys respond. I'll have a further look.
>
> Anyway, keys working with hid-microsoft also work with
> hid-multitouch, so It's ready for merging, I think.
>
> On 12/15/2015 01:39 AM, Donavan Lance wrote:
>> On Mon, Dec 14, 2015 at 8:22 AM, Bastien Nocera
>> <hadess@hadess.net>
> wrote:
>>> On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote:
>>>> Use multitouch driver instead of microsoft one for Microsoft
>>>> Surface Type Covers.
>>>>
>>>> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as
>>>> well as the multitouch pads do.
>>>
>>> I've discussed this a couple of weeks back with Benjamin
>>> Tissoires, and this patch would break the special keys (mute,
>>> brightness up/down, keyboard backlight up/down and
>>> play/pause).
>>>
>>> The recommended way to fix this was to move multi-touch
>>> processing into the Microsoft driver, so that it would handle
>>> the trackpad's multi- touch events.
>>>
>>> You should be able to do this by carefully picking up the
>>> handling code from hid-multitouch, or do something similar to
>>> what's done in hid- wacom, which has the same problem as the
>>> Type Cover handling.
>>>
>>> Can you confirm that this does indeed break those special
>>> keys? If it does, it's a NAK from my side.
>>
>> For what it's worth the special keys on my keyboard work fine
>> when using this patch. I'm using a Surface Pro 3, Type Cover 3,
>> running GNOME and Fedora 23. The search, share, connect(?), and
>> settings keys are the only ones not mapped to anything out of the
>> box, but they are recognized by xev.
>>
next prev parent reply other threads:[~2015-12-18 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 12:50 [PATCH 1/2] HID: Use multitouch driver for Type Covers Akihiko Odaki
2015-12-14 12:50 ` [PATCH 2/2] HID: Add new Japanese Surface 3 Pro Type Cover Akihiko Odaki
2015-12-14 13:22 ` [PATCH 1/2] HID: Use multitouch driver for Type Covers Bastien Nocera
2015-12-14 16:39 ` Donavan Lance
2015-12-18 6:28 ` Akihiko Odaki
2015-12-18 9:12 ` Akihiko Odaki [this message]
2015-12-18 10:41 ` Benjamin Tissoires
2015-12-18 15:06 ` Bastien Nocera
2015-12-19 1:34 ` Akihiko Odaki
2016-04-05 12:42 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5673CE04.90705@stu.hosei.ac.jp \
--to=akihiko.odaki.4i@stu.hosei.ac.jp \
--cc=benjamin.tissoires@gmail.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tusklahoma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).