From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933213AbbLROdi (ORCPT ); Fri, 18 Dec 2015 09:33:38 -0500 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34102 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933122AbbLROde (ORCPT ); Fri, 18 Dec 2015 09:33:34 -0500 Subject: Re: [PATCH v4] extcon: add Maxim MAX3355 driver To: Chanwoo Choi , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1767472.2Rx4LOCrWY@wasted.cogentembedded.com> <56735DFD.1070608@samsung.com> Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov Message-ID: <5674193A.6080909@cogentembedded.com> Date: Fri, 18 Dec 2015 17:33:30 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56735DFD.1070608@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/18/2015 4:14 AM, Chanwoo Choi wrote: > Except for just one comment below, Looks good to me. > Acked-by: Chanwoo Choi > I'll wait for a few days to get the review from DT maintainer > before applying it on extcon-next branch. > On 2015년 12월 18일 07:47, Sergei Shtylyov wrote: >> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to >> enable a system with an integrated USB OTG dual-role transceiver to >> function as an USB OTG dual-role device. In addition to sensing/controlling >> Vbus, the chip also passes thru the ID signal from the USB OTG connector. >> On some Renesas boards, this signal is just fed into the SoC thru a GPIO >> pin -- there's no real OTG controller, only host and gadget USB controllers >> sharing the same USB bus; however, we'd like to allow host or gadget >> drivers to be loaded depending on the cable type, hence the need for the >> MAX3355 extcon driver. The Vbus status signals are also wired to GPIOs >> (however, we aren't currently interested in them), the OFFVBUS# signal is >> controlled by the host controllers, there's also the SHDN# signal wired to >> a GPIO, it should be driven high for the normal operation. >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> The patch is against the 'extcon-next' branch of the 'extcon.git' repo. >> >> Changes in version 4: >> - stopped calling kstrdup() for the device name; >> - removed unneeded 'owner' field initializer; >> - moved devm_extcon_allocate() call further down in the probe() method; >> - extended the driver copyright; >> - indented the continuation lines in the binding document. >> >> Changes in version 3: >> - reformatted the change log. >> >> Changes in version 2: >> - added the USB gadget cable support; >> - added the remove() driver method which drives SHDN# GPIO low to save power; >> - dropped vendor prefix from the ID GPIO property name; >> - changed the GPIO property name suffix to "-gpios"; >> - switched to usign extcon_set_cable_state_() API; >> - switched to using the gpiod/sleeping 'gpiolib' APIs; >> - addded error messages to max3355_probe(); >> - added IRQF_NO_SUSPEND flasg to the devm_request_threaded_irq() call; >> - renamed 'ret' variable to 'err' in max3355_probe(); >> - expanded the Kconfig entry help text; >> - added vendor name to the patch summary, the bindings document, the Kconfig >> entry, the driver heading comment, the module description, and the change log; >> - fixed up and reformatted the change log. >> >> Documentation/devicetree/bindings/extcon/extcon-max3355.txt | 21 + >> drivers/extcon/Kconfig | 8 >> drivers/extcon/Makefile | 1 >> drivers/extcon/extcon-max3355.c | 151 ++++++++++++ >> 4 files changed, 181 insertions(+) >> >> Index: extcon/Documentation/devicetree/bindings/extcon/extcon-max3355.txt >> =================================================================== >> --- /dev/null >> +++ extcon/Documentation/devicetree/bindings/extcon/extcon-max3355.txt >> @@ -0,0 +1,21 @@ >> +Maxim Integrated MAX3355 USB OTG chip >> +------------------------------------- >> + >> +MAX3355 integrates a charge pump and comparators to enable a system with an >> +integrated USB OTG dual-role transceiver to function as a USB OTG dual-role >> +device. >> + >> +Required properties: >> +- compatible: should be "maxim,max3355"; >> +- maxim,shdn-gpios: should contain a phandle and GPIO specifier for the GPIO pin >> + connected to the MAX3355's SHDN# pin; >> +- id-gpios: should contain a phandle and GPIO specifier for the GPIO pin >> + connected to the MAX3355's ID_OUT pin. >> + >> +Example (Koelsch board): > > You mean that "koelsch" board might be arch/arm/boot/dts/r8a7791-koelsch.dts. > But, the max3355 dt node isn't really included in r8a7791-koelsch.dts. Of course, I couldn't post the device tree patch before the binding was accepted. > I recommend that you add the accurate information because the wrong > info causes the confusion. So, I'd like you to change it as following: > > "Example (Koelsch board):" -> "Example:" > > After adding the max3355 dt node to Koelsch board on separate patch, > you modify this documentation for real usage case of max3355 dt node. No dire need to modify the documentation then. Should I still repost? [...] > Thanks, > Chanwoo Choi MBR, Sergei