From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932971AbbLRQeS (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Dec 2015 11:34:18 -0500
Received: from mail-pf0-f179.google.com ([209.85.192.179]:34168 "EHLO
	mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932264AbbLRQeP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Dec 2015 11:34:15 -0500
Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM
To: Sebastian Frias <sf84@laposte.net>
References: <5672D89A.4090307@laposte.net>
 <yw1xoadpcbbn.fsf@unicorn.mansr.com> <5672F9C9.1010601@laposte.net>
 <5673E3FD.8080001@laposte.net> <56742F23.5010501@hurleysoftware.com>
 <56743405.8020408@laposte.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= <mans@mansr.com>,
        linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Mason <slash.tmp@free.fr>, Jon Anders Haugum <jonah@omegav.ntnu.no>
From: Peter Hurley <peter@hurleysoftware.com>
Message-ID: <56743584.50500@hurleysoftware.com>
Date: Fri, 18 Dec 2015 08:34:12 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <56743405.8020408@laposte.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/18/2015 08:27 AM, Sebastian Frias wrote:
> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>> -    unsigned char old_dll, old_dlm, old_lcr;
>>> +    unsigned char old_lcr;
>>>       unsigned int id;
>>> +    unsigned int old_dl;
>>
>>     unsigned int id, old_dl;
> 
> Ok, thanks for your comments.
> By the way, should I just do:
> 
> -    unsigned char old_dll, old_dlm, old_lcr;
> +    unsigned char old_lcr, old_dl;
> 
> ?

The divisor is a 16-bit value.