From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932980AbbLRQfh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Dec 2015 11:35:37 -0500
Received: from smtpoutz26.laposte.net ([194.117.213.101]:42797 "EHLO
	smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S932294AbbLRQfg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Dec 2015 11:35:36 -0500
Message-ID: <567435D5.2040605@laposte.net>
Date: Fri, 18 Dec 2015 17:35:33 +0100
From: Sebastian Frias <sf84@laposte.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Peter Hurley <peter@hurleysoftware.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?B?TcOlbnMgUnU=?= =?UTF-8?B?bGxnw6VyZA==?= 
	<mans@mansr.com>,
        linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Mason <slash.tmp@free.fr>, Jon Anders Haugum <jonah@omegav.ntnu.no>
Subject: Re: [PATCH v2] use callbacks to access UART_DLL/UART_DLM
References: <5672D89A.4090307@laposte.net> <yw1xoadpcbbn.fsf@unicorn.mansr.com> <5672F9C9.1010601@laposte.net> <5673E3FD.8080001@laposte.net> <56742F23.5010501@hurleysoftware.com> <56743405.8020408@laposte.net> <56743584.50500@hurleysoftware.com>
In-Reply-To: <56743584.50500@hurleysoftware.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-VR-SrcIP: 83.142.147.193
X-VR-FullState: 0
X-VR-Score: -100
X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeekiedrfeehgdeludcutefuodetggdotefrodftvfcurfhrohhf
X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs
X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefkfffhfgggvffufhgjtgfgsehtjegrtddtfeejnecuhfhrohhmpefu
X-VR-Cause-4: vggsrghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgvrdhnvghtqeenucfrrghrrghm
X-VR-Cause-5: pehmohguvgepshhmthhpohhuthdphhgvlhhopegludejvddrvdejrddtrddvudegngdpihhnvghtpeek
X-VR-Cause-6: fedrudegvddrudegjedrudelfedpmhgrihhlfhhrohhmpehsfhekgeeslhgrphhoshhtvgdrnhgvthdp
X-VR-Cause-7: rhgtphhtthhopehpvghtvghrsehhuhhrlhgvhihsohhfthifrghrvgdrtghomh
X-VR-AvState: No
X-VR-State: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/18/2015 05:34 PM, Peter Hurley wrote:
> On 12/18/2015 08:27 AM, Sebastian Frias wrote:
>> On 12/18/2015 05:06 PM, Peter Hurley wrote:
>>>> -    unsigned char old_dll, old_dlm, old_lcr;
>>>> +    unsigned char old_lcr;
>>>>        unsigned int id;
>>>> +    unsigned int old_dl;
>>>
>>>      unsigned int id, old_dl;
>>
>> Ok, thanks for your comments.
>> By the way, should I just do:
>>
>> -    unsigned char old_dll, old_dlm, old_lcr;
>> +    unsigned char old_lcr, old_dl;
>>
>> ?
>
> The divisor is a 16-bit value.
>

You are right, I was too eager to "reduce the amount of lines that 
change"...