From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbbLUMDv (ORCPT ); Mon, 21 Dec 2015 07:03:51 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:60804 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbbLUMDs (ORCPT ); Mon, 21 Dec 2015 07:03:48 -0500 Subject: Re: [PATCH v5 0/5] Add memory mapped read support for ti-qspi To: Tony Lindgren , Brian Norris , Mark Brown References: <1449807000-6457-1-git-send-email-vigneshr@ti.com> CC: Rob Herring , Russell King , , , , , , , From: Vignesh R Message-ID: <5677EA76.6000108@ti.com> Date: Mon, 21 Dec 2015 17:33:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449807000-6457-1-git-send-email-vigneshr@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2015 09:39 AM, Vignesh R wrote: > Changes since v4: > Use syscon to access system control module register in ti-qspi driver. > > Changes since v3: > Rework to introduce spi_flash_read_message struct. > Support different opcode/addr/data formats as per Brian's suggestion > here: https://lkml.org/lkml/2015/11/11/454 > Gentle Ping on the series... > Changes since v2: > Remove mmap_lock_mutex. > Optimize enable/disable of mmap mode. > > Changes since v1: > Introduce API in SPI core that MTD flash driver can call for mmap read > instead of directly calling spi-master driver callback. This API makes > sure that SPI core msg queue is locked during mmap transfers. > v1: https://lkml.org/lkml/2015/9/4/103 > > > Cover letter: > > This patch series adds support for memory mapped read port of ti-qspi. > ti-qspi has a special memory mapped port through which SPI flash > memories can be accessed directly via SoC specific memory region. > > First patch adds a method to pass flash specific information like read > opcode, dummy bytes etc and to request mmap read. Second patch > implements mmap read method in ti-qspi driver. Patch 3 adapts m25p80 to > use mmap read method before trying normal SPI transfer. Patch 4 and 5 > add memory map region DT entries for DRA7xx and AM43xx SoCs. > > This patch series is based on the discussions here: > http://www.spinics.net/lists/linux-spi/msg04796.html > > Tested on DRA74 EVM and AM437x-SK. > Read performance increases from ~100kB/s to ~2.5MB/s. > > Vignesh R (5): > spi: introduce accelerated read support for spi flash devices > spi: spi-ti-qspi: add mmap mode read support > mtd: devices: m25p80: add support for mmap read request > ARM: dts: DRA7: add entry for qspi mmap region > ARM: dts: AM4372: add entry for qspi mmap region > > Documentation/devicetree/bindings/spi/ti_qspi.txt | 22 +++- > arch/arm/boot/dts/am4372.dtsi | 4 +- > arch/arm/boot/dts/dra7.dtsi | 6 +- > drivers/mtd/devices/m25p80.c | 20 ++++ > drivers/spi/spi-ti-qspi.c | 139 +++++++++++++++++----- > drivers/spi/spi.c | 45 +++++++ > include/linux/spi/spi.h | 41 +++++++ > 7 files changed, 243 insertions(+), 34 deletions(-) > -- Regards Vignesh