From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753154AbbLXMgz (ORCPT ); Thu, 24 Dec 2015 07:36:55 -0500 Received: from mout.web.de ([212.227.17.11]:52400 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbbLXMgx (ORCPT ); Thu, 24 Dec 2015 07:36:53 -0500 Subject: [PATCH 2/3] Documentation-getdelays: Apply a recommendation from "checkpatch.pl" in main() To: linux-doc@vger.kernel.org, Jonathan Corbet References: <566ABCD9.1060404@users.sourceforge.net> <567BE5AA.6070607@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <567BE6E0.6040405@users.sourceforge.net> Date: Thu, 24 Dec 2015 13:36:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567BE5AA.6070607@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fiq/TrQyaNCHNQvfe9SBDoLqnYwrAVZkM+sBeThYkNVHfMlriYe 1OLUDcV90kJpznx+kYQa9VewoHejT17BOeT9wxGINs9lxEougZVFF5C8OCNvILz3cx7203E Fv/iBvQiiReX895yryueCJiXHZu/DB6N3BZ0AZ7q18f0ZxALxabK/Y9xJn8IwYiSLR/hWXL 4n0rLGX8jOJiUDlrQLs/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:eGod68hZvNs=:1FU1+J3O8HwoOI7C0cQomL 90Lu1hIqJdffMEAGMMGgcx+W2av8zzgmXczAeSs9SIIuZyXfKNsPosMGpt0dUvD3vDX0l+Ud2 3I4YlYe1Tvy2/mEHngwfD+KZr1V1m7gq5Zy++vxYIUmJJ8de/JYTb+ClyQGlc9VDm6aMinomi 7FK5zacv+sEPqdfdJnvgfXnNj72bfE2kPaYTwwr5njfNCiCztyy+oioWuvJdiDOSmWR7yzp4C ySr0Ey5ZQaAbo/aCjbbcLEBgFvgBjL3cNB0oNSU0a9i68NTmJguTY4zGJ6oodChulxicVjP9u zB0ZZxpNxrzMjg0BM2kILMkUE/DBJCZ5XCQW0zk1Vf/LQ4vI6ODbd7CNh4K2kPQ5hCyWZ4AIF R4t45I58EOdWu/50Wo7KQQYAuNB5PUfuD5QzKRkpNElwYRo9xGGz1e/AP9ahamyMZbm9uTsYN bOfyrAelBB5cHfCeaTgQoPSJfQSEpOyyKqnS/XrZ2Eh9LMJ0nMfn/7WDQwE1BqCnLs0P5SMTK +gxTm/MPS61ED4BSLvN9sT5KxEgN25m6DI6w35s8LkgINMQ0a+KQctov2TcAb/Hk1Qx1xj7Od XopgApRD9O2CvtvLZfjBpl0ziLM/xbvOp4E1BBXqWOLvsWEbfRZBqwIer4jDGYIV/v+WAf97U Wkn0JYNp2fQAeuMXt9XY6G2fZTXBcUTvUh+B/jeENkx3l1Ykmykk8OXC/5CnprkVipZafvx6X QoCq22ER4td6hdEk3vCgXDS9uF4Fv8qhpy8vD8bDlcc8TCOFC3ORyvc0qxuFy74stfZVb91Ll HAK9uKG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 24 Dec 2015 11:05:32 +0100 The script "checkpatch.pl" pointed out that assignments should usually not be performed within condition checks. Thus move the assignment for the variable "nl_sd" to a separate statement. Signed-off-by: Markus Elfring --- Documentation/accounting/getdelays.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c index 6656c0c..9ca318d 100644 --- a/Documentation/accounting/getdelays.c +++ b/Documentation/accounting/getdelays.c @@ -375,7 +375,8 @@ int main(int argc, char *argv[]) } } - if ((nl_sd = create_nl_socket(NETLINK_GENERIC)) < 0) + nl_sd = create_nl_socket(NETLINK_GENERIC); + if (nl_sd < 0) err(1, "error creating Netlink socket\n"); -- 2.6.3