From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbbLYKg2 (ORCPT ); Fri, 25 Dec 2015 05:36:28 -0500 Received: from mout.web.de ([212.227.17.11]:65272 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbLYKg0 (ORCPT ); Fri, 25 Dec 2015 05:36:26 -0500 Subject: ACPI-fan: Another source code review around null pointer handling? References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <567D1BF1.6060701@users.sourceforge.net> Date: Fri, 25 Dec 2015 11:35:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CAewIQ5wIw3nPZQy6TLtbLa+IA6jX9PGWppF2ddO4H3oqCVQmo4 e6e5JDvVk0xjeJp9USx1AtwDsJircGc6/+W8eQ41IbX3IH+3xAdMwoQtxHiV1meoLKfCV8o JVtRaw/G3Q/6OR1OtkknutGF8+g5jj8/919ZesXwVERO+LHzEm7++I9upxSIXIVTg2Z8PcF /EheT4XfXVJDQCa4ucGJg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MyUCeXrHPoM=:htISy5y2gfSc/o8bFdbbsb 9W538stBKU9koWFwYBci1AUXuWuS3UQLCMgiw3XtiRuJpWCzmTmRFB9W58YlzyAzOFNJZPKmu cJnpfa+wkCrGLLGEv/2JpQryydX4LMhD+ZcJiTNiaXe6CRlxSZpiUyRw6usqAzXQ2SCUUCNxP t3qrdnY3OBrZQezQbIqa9MGsDHkVVMiLWljHSTTnQ4r7kCL6avuJ8LW/NM21p060HBUfmL0nL o7CksH19SF8reC24PxyTKiwlMvK3tDimGcCTdUnBp9zKyhwwtJ6rJOGf8NZYJlYcXbTbtBP3o 1DKVyxb/X5dqv6lKxEPuV7imCV60U/BZe5Axk0rxwjscum6ILBvR16AHtzH7fTHNhfH/+rHel h3SRoxO0HiHP2cN91LavMKKluKfhB5uoCkzO7CmIrYu1OSZQEyg7q7ybdZ292DpbY1jJz383t 5P/liu08uArNp04wto/zlY4nQY2WaJho2YTHZfBoaea7RFsHRCPne6mtEj1Jphc1JdHs3q7im dO15BbuyrOSa6OZKOL4OCbs5FjpcCapQk5Gluy3c8bfkE1p8nktk31ETvTUsYsO8s5ulHszpK 44iEc2O6UvfLWFtgYldBDuB0JqzxCfBOeMvo/mozQykzQ7iLv89PVSS77PYp/fLREMtNnIWd0 yCPAUewornK+Efp9oe1lZb8FjKaFa+cm9OR7mpW/ThyKprfu2hfTwIuWPlCbqb0h1uJ0beG7L D0YIVXmZtUxDfiY2fHsjUd/bM9uKk8SOc2noROnhZ6QOE90R56bX2KF7rfTXEIGKDDI1hH/WI KNPIF59 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, I have looked at the source file for the ACPI fan driver once more. I would appreciate if a specific implementation detail can be clarified there. Static source code analysis can point out that functions like the following share an approach for error detection and corresponding exception handling. * acpi_fan_get_fif * acpi_fan_get_fps * fan_get_state_acpi4 https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/acpi/fan.c?id=80c75a0f1d81922bf322c0634d1e1a15825a89e6#n107 Can it matter eventually to handle a detected null pointer differently from further checks for an attribute like "obj->type" or "obj->package"? Regards, Markus