From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751811AbbLZTaj (ORCPT ); Sat, 26 Dec 2015 14:30:39 -0500 Received: from mout.web.de ([212.227.17.11]:64262 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbbLZTag (ORCPT ); Sat, 26 Dec 2015 14:30:36 -0500 Subject: Re: i2c-core: One function call less in acpi_i2c_space_handler() after error detection To: Wolfram Sang References: <201512261449.pmBxYtq3%fengguang.wu@intel.com> <567E3CF3.10606@users.sourceforge.net> <20151226074859.GA905@tetsubishi> <567E553B.5080005@users.sourceforge.net> <20151226184152.GA882@tetsubishi> Cc: linux-i2c@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <567EEAD5.4060108@users.sourceforge.net> Date: Sat, 26 Dec 2015 20:30:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151226184152.GA882@tetsubishi> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:sKqa4rtUpd06qUiIMenKG0zw9BAJovdcaBlBiH+TapWKhqvdHoW ikEHkVLZyRToYx8Kh2vx4lN84EqN1kZKXnu1lQAhGi1rsRKllo6wQJ2uGk7kEEXWn16jGSg 6eHwREqyxk7hYYDCRfELp0S2E6bePHQCEcqrIf0g7NmicTajZdbglT9kwGaOFvboE5k5jq3 cC7oqN4lHOOoesWTdL0rQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:sfeXKGGpqis=:hPCt+TAjdw6bjqn+I65r9f m/fu0fjXMDSpvs0ih28TGCiD7vKgKWzPg36I6fAdUveMRsIy/Pgyi6ULfPl3PxGUWFSoHJ45Q 0E9CLPkzHinbm5v9oPK8iJUtip6+DNsL/9daYp4ieIWxBhdWoIoN5NNNlPxOC8QupOIA3WsTJ gnbdLWSISYwJgnYkUIHsgNvao9v9WEC+ti5ngdwazsUrcuQVFzx9k4s2oFUL7mgFuDwvi1xqq SMlssMdgqbZPsEUskpQ5mXZSipAe4gkagUZzpmXzm6jgvz69Muqv2LeHdPuO4cZ5qsANO5zs7 lqtHJtUzWW+5bNGfFMBeGXqapeN5HMt5r/7CQky4BHP03Erey5e5BiQFPcfE9QgqTRVG3x+fQ j1upOMi/An21d4yfrexEeCftczVUJWwUqziECt1Kqp0T7Zd+z/GtKXjJ3pZs9M517+lWSwyiJ pPvU+bgy1dGej4+V6AkHU9MTB2d3pAI9N+I9Ggq+FUqnrIz1BIUSanrunkob8bGSG9sbkdNtr u2DoCC3QA2uYihIZB6JJSvf7hvKSgAvZxc8XB+40bpWLvdzQW3op0ehIrrpFz5BVqzd3+iBid WtvGsB4n3/hbVxY/EPbkHDGrpJIUAz4RiFDAAFo01bjciGdl/U5MGYDjRJNDsln+Dq91eew0Y diGC/cCcfYqYcJgXuT+h9NB+Ucn7LhzMTtex4Itq4+yoD+QtM0KdhKNASeEMbZkEu2nwyIWB6 UGfA86QvSdu8sZlftgZgkzEFVy2UhFKQYElEjLSTsHVcxoQWI2HWLWBeiR3R7pFZyO8ZcJ49C MjfccQn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I would appreciate if an unnecessary function call can be avoided here >> so that the affected exception handling can become also a bit more efficient. > > Simpler code is easier to maintain. There are different opinions available around the desired simplicity. > See your patch, you didn't get it correctly at your first try. I wonder myself about the circumstances on how my incomplete update suggestion did happen. > Also, this is not a hot path, I'm curious if approaches around better exception handling can eventually become a "hot topic". > so I see it as a micro-optimization I can agree to this view for this function implementation. > also adding complexity. There are the usual software development trade-offs. > I don't favor that. Thanks for your constructive feedback. Is an identifier like "free_client" a bit nicer (according to the Linux coding style recommendations) than the short jump label "err" in the discussed use case? Regards, Markus