From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2928C433ED for ; Mon, 17 May 2021 01:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD9CB6117A for ; Mon, 17 May 2021 01:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232112AbhEQBU1 (ORCPT ); Sun, 16 May 2021 21:20:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2981 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhEQBUX (ORCPT ); Sun, 16 May 2021 21:20:23 -0400 Received: from dggems701-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fk1Qz3C1RzQpQh; Mon, 17 May 2021 09:15:39 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems701-chm.china.huawei.com (10.3.19.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 17 May 2021 09:19:06 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 17 May 2021 09:19:06 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: return success if there is no work to do To: , , CC: , References: <20210515180941.1751362-1-trix@redhat.com> From: Chao Yu Message-ID: <567d4fcd-6e02-d80e-33cb-3a6810bf833a@huawei.com> Date: Mon, 17 May 2021 09:19:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210515180941.1751362-1-trix@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/16 2:09, trix@redhat.com wrote: > From: Tom Rix > > Static analysis reports this problem > file.c:3206:2: warning: Undefined or garbage value returned to caller > return err; > ^~~~~~~~~~ > > err is only set if there is some work to do. Because the loop returns > immediately on an error, if all the work was done, a 0 would be returned. > Instead of checking the unlikely case that there was no work to do, > change the return of err to 0. > > Signed-off-by: Tom Rix Reviewed-by: Chao Yu Thanks,