From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbbL1Ka5 (ORCPT ); Mon, 28 Dec 2015 05:30:57 -0500 Received: from mout.web.de ([212.227.17.12]:54078 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751846AbbL1Kay (ORCPT ); Mon, 28 Dec 2015 05:30:54 -0500 Subject: Re: [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <5680FDB3.7060305@users.sourceforge.net> Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56810F56.4080306@users.sourceforge.net> Date: Mon, 28 Dec 2015 11:30:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:4D1EKGPLByuRc+KzeOH/NQOC0afkEGNjsG2mE3NKimy41mWysZ9 RrJRE/xmt6rvTOkYW6f9ce5z6pSPkBmwlAvCeVKTe71e5Nb+31dYXxAxerQX+Jt7GWgoHIS sngavIkFhIcvOZ28RvoyuVwJsbdrUjdddLeVBZITzrGtJoktFY6U1P4jSo+0ecRhu2/DWPz FTp7LNpZjZfdjkYte2gtg== X-UI-Out-Filterresults: notjunk:1;V01:K0:xXD3hrF6sig=:/Cs2NDfZAyEsjI/HTYPPCC b5LKbzbvsUFV4Kqakw6XwKYzW/xhhInO+fKM8VE0Cb24dkvgd+1kMvohSq5a41Afp1I3JqTnV xPQaayRe6VbTMTOpgKaIJbLWmuA1VJ5/NWnfEVgmHP5AU6weDZ1LHoQSjhFtdYuPYgyhcEbqh JR6bVnlRdBfZZK9w6vtbyX1xgI/kavkkA760K4ZFUxJ1GOax1BnxRGLA1vgTM2y2au+uWfi5V uAaWTxbWQ6KgX30Xd8iia77tUvF8A4XPY4cbHOGnnfQe20MyLt0sdRtQ3YD5Xo9uy+tp+bR7n r3X5ELnxDwh/kImyRUZRJbMa4EbNFKL5guVvHOz5dTlDj6TGiOh+TPmWM8S6GmA3r7g+JPgk4 8aeIaFgyO8ysfCiqoatAtuMPIkyc9uvIvPCzz+nVnUwGreC0FboMyYHsjrY/lIFAswH6H6A6j NW+OWbEB2VqRC9z4gmjI+WWsh0WK5AVi/U8dmKpsVkD63zKUXDgYNaFK8Mt2SvBJ/B6O/Colq irPMP3dQb9ILhg4lIqHP5rmCxiwm0iPR5hq5nabM73VXDXaBtBqA3Q5UTJy1ayFfOnK7dDTuu 1fceHN5+DU9N4iC4h0dlzIE+mhzZCSFE0jRq8TfYQq7JIYo1siZmDV5qsDVI5KO9wtfBLnJXN DkO1/hOhFdPAWKkoy7qNGjkQn63Rk1ZN+hJE7ZrhSGMkuzMp7bl5y6nNjCtAJqBW1RVE2QTQa bS4zVUO7s53DKYwB2ObTQEl4zz26CIv3bb/96vINiOXCQB39G0/k+RqgQMx+/7ssDgW3MfGWO qevuyLWO7Cymh3aEEs9Om3daKIMGg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Move the jump label directly before the desired log statement >> so that the variable "ret" will not be checked once more >> after it was determined that a function call failed. > > Why not avoid both unnecessary ifs I would find such a fine-tuning also nice in principle at more source code places. > and the enormous ugliness of a label inside an if by making two returns: > a return 0 for success and a dev_dbg and return ret for failure? How should your suggestion finally work when the desired execution success can be determined for such functions only after several other calls succeeded? Is consistent checking of failure predicates usually required? Regards, Markus