From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751910AbcAAMu2 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jan 2016 07:50:28 -0500
Received: from mout.web.de ([212.227.17.11]:59519 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751638AbcAAMuZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jan 2016 07:50:25 -0500
Subject: Re: [PATCH 1/3] net-gianfar: Less function calls in
 gfar_ethflow_to_filer_table() after error detection
To: Julia Lawall <julia.lawall@lip6.fr>
References: <566ABCD9.1060404@users.sourceforge.net>
 <56866E7F.8080609@users.sourceforge.net>
 <56866F68.6070904@users.sourceforge.net>
 <alpine.DEB.2.02.1601011334200.2054@localhost6.localdomain6>
Cc: netdev@vger.kernel.org, Claudiu Manoil <claudiu.manoil@freescale.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <56867607.4090907@users.sourceforge.net>
Date: Fri, 1 Jan 2016 13:50:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1601011334200.2054@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:7sLH7VHWr0mev828ZEkb+KNIBK7HOMtrBM4RWOm/i5czuUTA4/J
 VVJm1qYYJqe0jjDwVdvFuRUy+fc66NFKyh9KeaJqvhZoaWYTqfB8OSm6QAdXIIlzCIBv4Mr
 0CA2Q/QdAwWenGtfOL5V4UxErvpuHPCzLzSqXArRRQ/hu2FC2QZzxwW/3nsYOYl/prKHfBQ
 SChNWXlNjeBVc+kQ3Hljg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:GOUtH7o7hhc=:CX5mrzczHJFfTp6BkFVknN
 +KXapkbKgD9WUfl40yX3jx73ZSu0c7sWpl1u0JXdtKtDMzH4QMGjUtyXQkN+Lvm/n+/2I17Kz
 cZ/NHrh/wyQER6rCJuDOHGxEXU7SALV8gWgJ7C0MlPXsvAdsRzggXI/xek5Z8dET1QOY+iwQp
 NkaFVSZznAAJHboxVn8Wbfr1yQ5KqzZrhCD+LssN2c2A2oeIYQBg4eN+U/hE1Si5DSlO44H2Z
 jP7bq1HC+AlFE7jXfIe6fvPhSnzLf2Wm8nzn+PNMTP2hosneaukRg2UL2QfbHpMnqgvVAV+y1
 ATs1sdYApcAbw/YJBr0yo20ENUzrFh2fslSklDIRi6m3vvWUhCSPJi2LhTp47pZs+thywSkTw
 GlHt1TJhkKoi7A0/A6XxumdzkE/F190CstF06X67zOCaRTAr/fx32pUSc+fiKSRbb/9oWRVIr
 5l6V3+6aZgjC+S1uK9e4Gz85Fry+WXwZflkWp0S5Ur2c+jMowkP2ZBr1npKmHwSG3PuJoeM0Y
 T7bqsxwhGQjnlhjTuT0XeEFKSuX2T6fj2hY0RB8rEc58cZGYk4z1TcmZd+nCMfFy0v6tRhxxP
 jPoMUNkyVBmnkMSiAXHGjkLWPepoF6z0QpgZgO3CQk0if7QBpUJLMlfq0Z81eY37iZS0WvZ52
 vVoHNXriSsggpM8+pjZ2Vl7k42q91eRr1aVbs17PdfwioUsNTwo1p0CoFt2HcwDAVagFIsOVf
 LlePSzMHwn0gGLqIXPm55nNKb7o2SXkYdB6UB9LhcZTmadEeG9YNnILk8SxGuLO0sVL5rc8M4
 ovG4e1r
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
>> @@ -778,11 +778,13 @@ static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow,
>>  
>>  	local_rqfpr = kmalloc_array(MAX_FILER_IDX + 1, sizeof(unsigned int),
>>  				    GFP_KERNEL);
>> +	if (!local_rqfpr)
>> +		return 1;
> 
> Why return 1?  Previously 0 was returned.

You are right. - Unfortunately, I made a mistake at this place
of my update suggestion.


> Normally, one returns -ENOMEM for this case, but it looks like this 
> function is returning 0 on failure.

Should a symbol like "false" be used instead of such a special number?

Regards,
Markus