From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751902AbcABIKH (ORCPT ); Sat, 2 Jan 2016 03:10:07 -0500 Received: from mout.web.de ([212.227.17.11]:50966 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbcABIKE (ORCPT ); Sat, 2 Jan 2016 03:10:04 -0500 Subject: Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker() To: Sergei Shtylyov , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo References: <566ABCD9.1060404@users.sourceforge.net> <5686F0B2.5000000@users.sourceforge.net> <56870866.7020000@cogentembedded.com> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568785B3.5000905@users.sourceforge.net> Date: Sat, 2 Jan 2016 09:09:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56870866.7020000@cogentembedded.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:b4czstu8CBIbDXf/5r9GUD70966JNv2Vu4uQPLK4jwYdNm2B3eY XoeZIQQ2nZ0bM7ggPv3tgQCG0lmczea8QokLu+o1j+3M3HSRV2EfMbVWao5mXYuyVD7jueW dJsx/mzliY1GG9fR5lLXzHpNmG5JM4DxMKdctouBQriBs6sZhDuKDm798nNepLjyqeijyFO 2vAu+z095brN8/QJAPDHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:GAubBkFM8Uo=:JfZ83xVlD777TTSltXOPKY Oyg5Pf1wy8cMoCqyFtql8HaexcwqQZRhlyiwN5p+HEduUWc3ZYNurz7bGpfdgnkZPIVhwvxbs w+/TrKCPkERJR7VevK0UFzyDnoUzTQDxw5Cw9mOH0F537oOvBS0grk2fdW5ku6mD9Jezq1vfR R9u27GFkRjalgIAQyuzjOrMRDbr3XxyDR0mKOsYNncGcmiVx9G+mT3TpVec9t8Q2ovUKWG1lu rlxa1CiUA0dtHHujbN1MvWfhnRqa0T9u39pkTuED4dP3i/isYyVR6ICuKfzjQp0Ul14cxUcel OkO4mbnF2tPwhO081haRUtZfdpz9TJYT5hi9mPblxvoHYIYiX5q9iNuI2j5p5XHD7plXz1cdj RThwZyX9HudNswbmDduZtbaxNdaOZ0uRyt+N6g/lXkFV33VsE8ROf8Vc4osw+04JJRaSfBN4O mjxS7MYpj/ZrYLNFLYs3AM2bqLTmSvrUyNuMF/U/CqY7LwNqPfNuljuSzK+4UWZzv8wNuwGlS tmFYRDB9w6KAqC+jU8sQZcweKr46kIlbo89Zy91W2wO2WhWu+z7dB35YEWl/b9pXrVuG1ce5m KcEbgJTHjgpx5DNQNdzyXd4FIBtT/Zr5fMfyOk/CXWY5KBh/CNaCDh8yI+4+rLfAEM8GKAEAO CIH9b/33KMNVkjJVffBw4FE7h8nNYTCA2pOMze54OlLKt0Vh+mi/oBi+7GPpnheIVazc48TPk wt1jZO0/oUYpk47k7eeVTMWgdH4u797oRb7ZIAiQ4R7vgEwFHB56+o98Dgd7FSLC4Mn+UKbu5 9yhagkR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > > Why? I suggest to reconsider the places with which such a jump label is connected. > The code was smart enough Which action should really be performed after a failure was detected and handled a bit already? * Another condition check * Just additional error logging > and you're making it uglier that it needs to be. I assume that a software development taste can evolve, can't it? Regards, Markus