From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcACRZ1 (ORCPT ); Sun, 3 Jan 2016 12:25:27 -0500 Received: from mout.web.de ([212.227.17.11]:58194 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcACRZY (ORCPT ); Sun, 3 Jan 2016 12:25:24 -0500 Subject: Re: [PATCH 8/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_set_timer() To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E268.9090600@users.sourceforge.net> Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56895976.5040009@users.sourceforge.net> Date: Sun, 3 Jan 2016 18:25:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:+vYVn9hi8M7BAlzd2F3Dwj3X5c114a2uj9wee4eyV84+2EbOp96 pq+0AUdYx42OUY2mFn1YoFAtqGg2G6cDttxIWmJW8Rlufpq///TtQZRQNOIAtZsYgisQ9wq /Yz0VJN6fEl/o9s84HfE+aytcOxHIzHOOLS7HKPO9NaeVBDCxPITMbGs9w2ScqnMQcqx/wA TbmNYtf6mvceEi7w8DUtw== X-UI-Out-Filterresults: notjunk:1;V01:K0:OzxKEpz3r4E=:D1fQL91lb2v8A+iZaaaxc4 KGU0JdyS/nGmWwDlJUVQAe6Vj7OxJpYf2tNfK0Gd7SjD1fl/dyJH7CYF23kyPDk63+aJw0wLF ZTYBYgJfz3EPAoqf1sc7ajOoh1Is+xfoUjBPii6tDNXMv935cf39D6VcMsYFpDAviULXVV9/L voaHTBxmj4UQ9F2/TkJJha+Ej+aPKmyoeTdmS/ymZAyZt89Jxrl6ztIMG2mqhT0NK3n4JkGvo 8kVu158af1AxjDBplxmLqAsa98IbydeDaL5kxRzJfMpHpjPZhMe8e4SbwFsh5WQpnzN6haSOG 7YWOgN+l9RVq0aghGuFeRX95S6aZC44O1h9fvgz2+KQNFg0RHDoqOaGBe0r2Ic66rmxqKC/bo 6lgxyjn9BqDjXxFp3EDTm0+7/PnAqncT8UZHO0Wi/a7F9kmL4a2FcfQXNH2sAPSBhvAQCMka5 vSOWLqvDgidyDWQBJYeZOGUY3I1SPdWv7obp6jA4ESq4vk6noz6f5r7OWaUa+YoUG8zl7YGJQ yAsLdfS+T+j+DFcAvKcKHBcFhVdLrUIHG4w1GECQWLIzTQSIlGkHoynwdibQDZIiPyMo3ZWAA 3B+FWcp8Uqevocd2gCVPmwboA9tUmEVb1YcJlouIXuT31h9dDyJM+uVQkLINbD04q45AEUO+F ID0BLJOeTd9n84y+JyxKZOS0wFL2Co2r1//Hew9qRY15KFPHIg2JuNIddx2w+23LTl/2s6to1 dc0mrP852xc9ma05axxXRHE6ffxENs10KZIQgLOqH0HXLrsLU0Y2Cnvs2Drp7B6KsCtaacobO Z0j9RgL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK, >> - mask, ABB5ZES3_REG_TIM_CLK_TAC1); >> + ABB5ZES3_REG_TIM_CLK_TAC0 >> + | ABB5ZES3_REG_TIM_CLK_TAC1, >> + ABB5ZES3_REG_TIM_CLK_TAC1); > > This doesn't seem like an improvement. Interesting … > The concept (mask) has disappeared, I suggest to drop another local variable. Can the operator "Bitwise OR" be sufficient to indicate the concept "mask"? > the binary operation is strangely broken, Do you prefer an other source code formatting within the usual line length range? > and the function call has one more line of arguments, How should several long preprocessor symbols be combined together with indentation so that they will fit into the limit of 80 characters? > which all look sort of the same and thus are hard to understand. Is this an usual consequence from an ordinary name pattern? Regards, Markus