linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: "linux-samsung-soc@vger.kernel.org" 
	<linux-samsung-soc@vger.kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Odroid U3 mutex deadlock.
Date: Mon, 04 Jan 2016 11:38:29 +0100	[thread overview]
Message-ID: <568A4BA5.3090203@samsung.com> (raw)
In-Reply-To: <CANAwSgTrz8=9r9jkKQY_ZN3fsvBs9QpeTxLG1Ac_8SfAULoyHw@mail.gmail.com>

Hi Anand,

On 2016-01-02 06:14, Anand Moon wrote:
> Hi Krzysztof
>
> On 14 December 2015 at 05:15, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 12.12.2015 13:32, Anand Moon wrote:
>>> Hi Krzysztof,
>>>
>>> I am just observing this deadlock om my Odroid U3.
>> This is not a deadlock yet, just a report from lockdep. Could be a real
>> issue, could be false positive, maybe some locks miss nesting annotations.
>>
>> Typical information for bug report would be useful, like the exact
>> version (it is mentioned in lockdep report but is it really correct?)
>> and reproducibility. And of course git-bisect would be nice to have, see:
>> Documentation/BUG-HUNTING
>>
>> Best regards,
>> Krzysztof
>>
>>
> Thanks for your inputs. I narrowed down to this commit.
> ----------------------------------------------------------------------------------
> commit ec459c0c77faca53cf161830cb264e51bb1abba6
> Author: Marek Szyprowski <m.szyprowski@samsung.com>
> Date:   Wed Feb 4 23:44:15 2015 +0900
>
>      ARM: dts: add dependency between TV and LCD0 power domains for exynos4
>
>      TV Mixer needs both TV and LCD0 domains enabled to be fully operational.
>      This dependency is modelled by making TV power domains a sub-domain of
>      LCD0 power domain.
>
>      Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>      Signed-off-by: Kukjin Kim <kgene@kernel.org>
> -------------------------------------------------------------------------------------
> After reverting this I am not observing below lockdep warning report.
> But after reverting this patch I observer another bug.

The mentioned lockdep warning is a false positive. Such warning is 
reported for
every subdomain present in a system. As you noticed that removing dependency
between power domains also removes this warning, but it will introduce real
problems with power on/off sequences of graphics devices.

I will send a patch for genpd core fixing the deplock warning. Thanks for
reporting the issue and pointing a good place to start digging in the 
source :)

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


      reply	other threads:[~2016-01-04 10:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-12  4:32 Odroid U3 mutex deadlock Anand Moon
     [not found] ` <CAE-5t2stNAGnHSW1RG9Ek8Zas6c3wgdULYP9sFRw=9LyLz+rLA@mail.gmail.com>
2015-12-13  2:36   ` Anand Moon
2015-12-13 23:45 ` Krzysztof Kozlowski
2016-01-02  5:14   ` Anand Moon
2016-01-04 10:38     ` Marek Szyprowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568A4BA5.3090203@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).