From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbcADKoa (ORCPT ); Mon, 4 Jan 2016 05:44:30 -0500 Received: from mout.web.de ([212.227.15.14]:62726 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbcADKo2 (ORCPT ); Mon, 4 Jan 2016 05:44:28 -0500 Subject: Re: [PATCH 1/3] rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda> Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568A4CFF.8060600@users.sourceforge.net> Date: Mon, 4 Jan 2016 11:44:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160104092857.GD5284@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Qc2PVs6P18ph71nhq5m/PpzVnTldhIT3p3Gcf+RkR4axLgR3nQT A4sfB28ZwveuXol8KlSPy+NFJVByXOYYU8RFLSjdSVWXZuzGT64Wg9Bk0+vPQkFwlWWzPhr FkNzeqE+rCrstp4qiQbTmWkQ7PooD/6oNwu6aiO+ANEFWRHdlswPyqyFBUqYcqWbMFXLSOX 5NUvDy4xr/GGqA8OK0Yhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:POugwQDib8U=:q3GIbMOwQJdTjns7BCV1FJ GcVa1dS2niqTGsbAEe/paNkKsB9obEJC2xa79xUvrGB7YZQnGP3vP0bQc3DvRd67cBz7GEEwA cI5Ns/Y6B/gJmqR5opvhQY15mNhu6Ykh6PcaMykqYs6rcsiOV2S7BuJlmyfx7LOc9uwzk18mq Q2sJHqU4zpFN49YUGj3Q2OFjtmcsBJC7r4hFH5oC+eA1IdYYJG6As+g1SgVbejeMXNbZXzNT/ i7wuXYayfdPnW2MJmdUxMQQpnyw+wDECjuQuGK9Tg2QWDNw93ym3S+1dSXaR8ojW3KHJ08YLN WLgxDmbPUDHL/2Viir5u7QMucXbZgx84lq45pCOesOweGgI0tBMMTqp+r/H4O+U4Ib1ELcEii PueQ4zMzpCvXoHwpVnOmHR9qt8HIuA28Oqu97LRoLaB6zdT5QIw7sTHcSweX59OK2tC/KTKXC Gurt15X+kZ1UyiSzBJRY4KDP2h55LMKh5lsy3VLxwgNzy2I+VVQALtKunOOOWJvjABdqMi16G WLl59pj6jQ2SkTwfcdVZ6V2XBEoQqpWN2fCf5y6K4nhvs78j5Bz+d1VeAxi0+vPrrwZr7s7Ah fi8gw/lEw3geYumhpjIMyeDBnLFJVlDOYee8tZZ8iPnas/o6dfuGQY0KteR7NFOw8pAzD4Sw5 JGaKkmhIgNsK/C5hFpT9uOfVL3jPuOENyvzkrrqdFQDe3T9nYxsbZ9QBZAaHUuDd4yIhGnQba fwgSN0x6+mpZUSZD8cl//5s2Sh5oXMNoq7V+q7Is8oAcbWKD/txRztTsEc0rzrvJLbH2Zznpf LSJzadJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > These patches are labour intensive to review because you can't just do > it in the email client. Thanks for your general interest. > Also you were not able to review it properly yourself and introduced > a bug. I admit that it can happen during my software development that I overlook implementation details somehow. > I am often remove initializers but it's normally because I am changing > something else which makes it worthwhile. It is nice to hear that you are also occasionally looking for similar update candidates. > This patch is the correct thing but it's not "worthwhile". I find this view interesting. > Please stop sending cleanup patches, Markus. Just send fixes. How often will source code clean-up fix something? May I resend a consistent patch series for the source file "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future? Regards, Markus