From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbcAEGhL (ORCPT ); Tue, 5 Jan 2016 01:37:11 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:50042 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754039AbcAEGhH (ORCPT ); Tue, 5 Jan 2016 01:37:07 -0500 Message-ID: <568B638F.1030208@huawei.com> Date: Tue, 5 Jan 2016 14:32:47 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Namhyung Kim , Arnaldo Carvalho de Melo CC: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , "David Ahern" , Stephane Eranian , Andi Kleen , Masami Hiramatsu Subject: Re: [RFC/PATCH] perf report: Show random usage tip on the help line References: <1451972206-22481-1-git-send-email-namhyung@kernel.org> In-Reply-To: <1451972206-22481-1-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.568B63A5.001C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4613f50b1dbcc41b385b83fcd31dbac5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/5 13:36, Namhyung Kim wrote: > Currently perf report only shows a help message "For a higher level > overview, try: perf report --sort comm,dso" unconditionally (even if > the sort keys were used). Add more help tips and show randomly. > > Signed-off-by: Namhyung Kim > --- That's really funny. Some inconvenience: 1. Tip is never change during one execution of 'perf report', even if I switch to another view using 'enter' and switch back. It should better if tips updated when redrawing. 2. I think add a "Tip: " prefix to the content should be better, or users may confuse what he/her doing causes this message 3. What about creating a tools/perf/Documentation/tips.txt and generate tips table dynamically? Thank you.