From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751735AbcAEIaV (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jan 2016 03:30:21 -0500
Received: from mout.web.de ([212.227.17.11]:60771 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751221AbcAEIaR (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jan 2016 03:30:17 -0500
Subject: Re: rsi: Delete unnecessary variable initialisations in
 rsi_send_mgmt_pkt()
To: Julian Calaby <julian.calaby@gmail.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <5687E169.4070704@users.sourceforge.net>
 <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda>
 <568A4CFF.8060600@users.sourceforge.net> <20160104114849.GH5284@mwanda>
 <568A668D.8090007@users.sourceforge.net>
 <CAGRGNgXw+G6ZcmFmM=VWZT_jibuZyxe-kSvPSF8W7hPueLhNrw@mail.gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, Kalle Valo <kvalo@codeaurora.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <568B7F06.1010500@users.sourceforge.net>
Date: Tue, 5 Jan 2016 09:29:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAGRGNgXw+G6ZcmFmM=VWZT_jibuZyxe-kSvPSF8W7hPueLhNrw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:9e3SsqmKGNNdwXeFY9pY7wdv+E4XbfoLPmvu7whUkq48xyrPd8Y
 NuuSCx/wFuzjbpghyGj7SsslzilrhQqSBmPmuy6dGy9HRU7/lKsKhOOym4qQ0YnlQ8TLkVr
 YDtKCbMohQI73JuA6ywHrOoiNvpwo3rkhm1yf+SvrPOOUDiR7UXmQzR2dq1lTJwee/7m5c3
 1z1tqnyViF0FCLKTBLyLw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:JHn1lTn93qU=:v2o3Xq7od5onudIqtTQ5Nw
 CVcYElE1tfE72/XNjcnBErwDePA5kZAUe6u16nYsuI0V3F4sUxRV/j0x8YkDuw83HJrhC3zIc
 0azyl9oFr//nxCDcZ96IqnjeZxD2PuBkC3MRaodxiaNr9qDSyqFYw8vr01mhn+CFk+oTW9Ezb
 5rqJ1vae1nXBiRf/jRpDTA0NIcsnrxRwHJpzMCpk7OG/GshgYWPIn9nQWesRFVRObkqv42NtW
 PJ1YCx86r2CB9wyOyrHBIAouX+ijaXM3DmB/2I9k/ijK33t3FQ6kemvuPKppojO64pgqvG1TA
 JTS/2HDchej22AV37C22mwL6eRZ7MA+1e0uVPpYPHPgwWGg3/GIR3Hf3CWStEXKNYEwn3hvAm
 iKhEKaZHoBbtLzwiijfpgOguwYFakL7GO84PxBUoUqS1RUEr1i2rZN6w8aJHQtTAL/wWQwFYq
 Jrpr2oNxd1kv0kq7ADl8JEPu88x88FtSr4Aq1dFURWWLQAlKl6xZqpOUnp9bppoSmhPPZ7FkP
 ftiZjhL/c67BJr84NLEJknewVKKsTFYpnP71dFXcUecZ35tWsJBvoGv1sGCqSz1aaFAfKROqW
 Lcc7a+THpEaT0Jov+8kyKfhUji1QUj4SBFoGTsV6p1fwtNl0ByDm7olU6a61+pn5Jwk09WNkN
 AoT/FXtg5CLzcLnZEpVgN10e7ekQ0gtHJgfGgQwTKXCgb7ZowmflYIC+L911TCqMaOibvIpPR
 WxR6aiqN2U7077wTX5gq3ybIv6jUpfl8MJVB71x5UhOeixRvHZMc4UgDNjAndQK/kxBgf6XTb
 JpXcaU2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> That said, if you figure out some change that produces significant
> reductions in code or binary size on multiple architectures without
> making things more complicated, less readable or making the code or
> binary size larger, then by all means propose it.

Are you looking also for "a proof" that such changes are worthwhile?


> "This makes things smaller" carries much more weight than
> "I think this is better".

Can the discussed implementation of a function like "rsi_send_mgmt_pkt"
become a bit smaller by the deletion of extra variable initialisations


> Almost all of the changes you've proposed that have seen any
> discussion whatsoever fall into the latter category.

Thanks for your interesting feedback.

Can a further constructive dialogue evolve from the presented information?

Regards,
Markus