From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbcAEQXX (ORCPT ); Tue, 5 Jan 2016 11:23:23 -0500 Received: from mout.web.de ([212.227.17.12]:61290 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbcAEQXS (ORCPT ); Tue, 5 Jan 2016 11:23:18 -0500 Subject: Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt() To: Julian Calaby References: <566ABCD9.1060404@users.sourceforge.net> <5687E169.4070704@users.sourceforge.net> <5687E203.1070404@users.sourceforge.net> <20160104092857.GD5284@mwanda> <568A4CFF.8060600@users.sourceforge.net> <20160104114849.GH5284@mwanda> <568A668D.8090007@users.sourceforge.net> <568B7F06.1010500@users.sourceforge.net> Cc: Dan Carpenter , linux-wireless , netdev , Kalle Valo , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568BEDE8.4010203@users.sourceforge.net> Date: Tue, 5 Jan 2016 17:23:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:JrttJpNMqjamICDIzgF/NtcjSjhCP6JXob+/DRJC82uPaUspldP Lh9OJAoq6qPN6zKNDB/Imh0ZzVK5Hi3LByytTtCQjSyeGB+m897dMMHh1LB3gptbliEbd23 XS3Tzoarxsf1Rp6+RTQtfMXlUGBMexX3eQJ1c3cZSg9N0oNsYsNiOjaOdc03SGZA/3Eno+g pnsZsSyv2du03AKOUS4FA== X-UI-Out-Filterresults: notjunk:1;V01:K0:BlXsWn8/xPY=:XxKqyt0j3eRqigypBN/PS3 WF93q5J3DoRqGRHt6za1Cr+/cpGIpXYNO/lndqswVCpKa67C3+jGOUUi85AyiyXX0iz8Rfg3W Yv5YIZmVxsnAUPwy5VNJT34bl31Rv4skZ3EcdxzN8x8+BF9GRtbnlayW1YaWU53kQIuTBWKpb 1YGnC2a8XFu6aeahEzwmVVuCaLMb+adnrGPq+YGD/79UMJSp324fmBPPlcXE+d9sqML/VjJg6 M5gxzaFkOSgnMerXNfXh8IE/9Ge21A3oPz8ndXTjSx4Ua0g/TCs3/34mFXYXDgsnwYzK+x07u bKObZ3Js2GNlhQXpD3ez3vGSLdhvzJ3UotsdLV7pf6BAOfZ8tufaLrsLZEfSmwlVKOBRYhOoJ afFVt43y8qUnba6QHkpUSs7CrJB2CnAbCNMr/zc4pKYlivKvlQGDDUb0/duUn8rHnSFff2+/y q6CPaxx9fx0I5RWBAHYRgPD8lFqbctBrti6ZQTCorkzhfjlropyMgVd4LjbaNIiOh462HhAJB JhllZ6aV/1vFFahlnVqvmBGy5W+ElyEHZX2A8UqthCBT6L5uTTBzosvg1Vw3TjbIQM6458Fbb Ezq886DaLborBHP9MwRkswWT7heu4x+wLXaXVmfRDCC7RFb36Edz/vyCdCQIZqD/wVoYkqeUg 5HRvLnGqTLncWwqYkLehB4E5R9S07VzU9F5gYBz7WGUVTuwVSXFhYWDebhaeHMkEX/79iN01m MVSXEtRhXsM56eCg6Id2ATrcCrZch2Z0Yvv1YOzQsVxJWTnvhhdxHyv4+aWKK0V1mcqdoMQfy s0BUOha Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Every time you send a set of patches, I suggested some updates for Linux source files since October 2014. > there are legitimate issues which people raise, There was usual feedback. > and every time they are discussed, The discussion results were mixed between acceptance and usual disagreement. > you assert that your patches improve things I guess that should be the default intention of every patch, shouldn't it? > and seem to ignore the concerns people raise. I hope not. - But I can imagine that you might understand some responses from contributors in this way. Are you waiting for another clarification on a specific issue? > I've seen this same pattern of discussion here with these patches, > with your patches to move labels into if statements, with the patches > you sent late June last year, your patches to remove conditions before > kfree() and friends, etc. It seems that communication difficulties come partly from the fact that I chose search patterns from static source code analysis so far which belong to an error category that gets a lower priority. > You need to change you attitude: just because you can see some benefit > from your patches doesn't mean others do and it doesn't mean that > they're willing to accept them. I understand your advice. Further update suggestions with higher importance might follow for various software areas in the future. Regards, Markus