From: Timur Tabi <timur@codeaurora.org>
To: G Gregory <graeme.gregory@linaro.org>
Cc: Aleksey Makarov <aleksey.makarov@linaro.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
lkml <linux-kernel@vger.kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Shannon Zhao <shannon.zhao@linaro.org>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe
Date: Tue, 5 Jan 2016 10:23:08 -0600 [thread overview]
Message-ID: <568BEDEC.5010101@codeaurora.org> (raw)
In-Reply-To: <CAGCh1+ksWFLkE8Y_a5SW98tpgGBWdVH5TYJAoS17EExuPd65oQ@mail.gmail.com>
G Gregory wrote:
>> >I'm confused by this patch. We already have code like this in
>> >tty-next, in the form of sbsa_uart_probe():
>> >
>> >https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/tty/+/tty-next/drivers/tty/serial/amba-pl011.c#2553
>> >
> Because Russell expressed unhappiness at that code existing. So this
> is an alternative method to do same thing with ACPI.
FYI, this patch doesn't apply on tty-next as-is, so it would need to be
updated anyway. Then again, considering the latest drama with that
driver, who knows what it will look like?
> If the "arm,sbsa-uart" id was added to drivers/of/platform.c as an
> AMBA id then the same could be done for DT as well.
>
> Ultimately this patch is optional depending on maintainers opinion!
So with this patch, what is the difference between sbsa_uart_probe and
pl011_probe? Shouldn't the patch also remove sbsa_uart_probe?
next prev parent reply other threads:[~2016-01-05 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 14:19 [PATCH v4 0/3] Add AMBA bus probing support to ACPI Aleksey Makarov
2015-12-23 14:19 ` [PATCH v4 1/3] ACPI: amba bus probing support Aleksey Makarov
2015-12-23 18:49 ` Andy Shevchenko
2016-01-03 13:36 ` Russell King - ARM Linux
2015-12-23 14:19 ` [PATCH v4 2/3] ACPI: scan add in amba probing Aleksey Makarov
2015-12-23 14:19 ` [PATCH v4 3/3] serial: amba-pl011: add ACPI support to AMBA probe Aleksey Makarov
2016-01-04 23:13 ` Timur Tabi
2016-01-05 8:55 ` G Gregory
2016-01-05 16:23 ` Timur Tabi [this message]
2016-01-06 11:03 ` Graeme Gregory
2016-01-11 21:38 ` Timur Tabi
2016-01-03 0:39 ` [PATCH v4 0/3] Add AMBA bus probing support to ACPI Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BEDEC.5010101@codeaurora.org \
--to=timur@codeaurora.org \
--cc=aleksey.makarov@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=graeme.gregory@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
--cc=shannon.zhao@linaro.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).