From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbcAFNGP (ORCPT ); Wed, 6 Jan 2016 08:06:15 -0500 Received: from regular1.263xmail.com ([211.150.99.140]:36548 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbcAFNGN (ORCPT ); Wed, 6 Jan 2016 08:06:13 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: <2130be7abc2c105b3032dc890ae30848> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <568D1134.9010305@rock-chips.com> Date: Wed, 06 Jan 2016 21:05:56 +0800 From: Xing Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: =?GB2312?B?SGVpa28gU3SouWJuZXI=?= CC: Yakir Yang , Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Michael Turquette , Kumar Gala , Stephen Boyd , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, keescook@google.com, linux-clk@vger.kernel.org, leozwang@google.com, xing.zheng@rock-chips.com Subject: Re: [RESEND PATCH v1 4/4] clk: rockchip: rk3036: fix and add node id for emac clock References: <1451293433-32392-1-git-send-email-zhengxing@rock-chips.com> <5681E8E4.2010303@rock-chips.com> <5681F121.3070307@rock-chips.com> <1562268.fb58QJ4jV7@diego> <01110793-A349-4006-82A2-4489CE832B19@rock-chips.com> In-Reply-To: <01110793-A349-4006-82A2-4489CE832B19@rock-chips.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2016年01月02日 10:34, Xing Zheng wrote: > Hi Heiko, > Thank you for your patch, I will apply and test it later. > > Thanks. > >> 在 2016年1月2日，06:10，Heiko Stübner 写道： >> >> Hi Xing, >> >> Am Dienstag, 29. Dezember 2015, 10:34:09 schrieb Xing Zheng: >>> On 2015年12月29日 09:59, Yakir Yang wrote: >>>> On 12/28/2015 08:41 PM, Heiko Stübner wrote: >>>>> Am Montag, 28. Dezember 2015, 17:03:53 schrieb Xing Zheng: >>>>>> Due to referred old version TRM, there is incorrect emac clock node, >>>>>> we should fix it. The SEL_21_9 is the parent of SEL_21_4. >>>>>> >>>>>> In the emac driver, we need to refer HCLK_MAC, and because There are >>>>>> only 3PLLs (APLL/GPLL/DPLL) on the rk3036, most clock are under the >>>>>> GPLL, and it is unable to provide the accurate rate for mac_ref which >>>>>> need to 50MHz probability, we should let it under the APLL and are >>>>>> able to set the freq which integer multiples of 50MHz, so we add these >>>>>> emac node for reference. >>>>> I don't really follow here. While I do understand that the emac needs >>>>> 50MHz, I >>>>> don't think using the APLL as source is helpful. >>>>> >>>>> The APLL is the main clocksource for the cpu-cores, including frequency >>>>> scaling, and while it currently only lists 816MHz as sole frequency, >>>>> you're >>>>> pretty much guaranteed to not get your correct multiple of 50MHz from >>>>> there >>>>> either. And limiting the cpu to just do 600MHz to get the mac working >>>>> sounds >>>>> pretty bad ;-) . >>>>> >>>>> >>>>> In the rk3036 cru-node the gpll gets set to 594MHz. Is there a >>>>> special reason >>>>> why it needs to be 594MHz and cannot be a round 600MHz? Because that >>>>> would >>>>> also provide your 50MHz-multiple nicely. >>>> Yes, this magic 594MHz would help to support the standard HDMI >>>> resolutions, here are the math: >>>> >>>> 1920x1080-60Hz DCLK = 148.5MHz = 594MHz / 4 >>>> 1280x720-60Hz DCLK = 74.25MHz = 594MHz / 8 >>>> 720x480-60Hz DCLK = 27MHz = 594MHz / 22 >>>> >>>> Thanks, >>>> - Yakir >>> Thanks Yakir. >>> >>> Hi Heiko, >>> From the above, do you have better idea for the RK3036's emac without >>> ext-oscillator? >> During the last days I did play a bit with the clock framework. As I don't >> have a Kylin (or any rk3036) board, I did build a test-case with pclk_cpu on >> the rk3188 (which can be affected by the armclk if not reparented to the >> gpll), which got sucessfully adapted to get back to (or near) the originally >> requested frequency. >> >> So ideally you could roll back your mux/div split here and try the attached >> diff. In theory it should help :-) . >> As can be seen by the FIXMEs, not fully finished, but I'd like to determine if >> it fixes the issue at least. >> >> >> Heiko >> I tested your patch just now, it seems to work well. I will do more tests. Thank you. :-)