From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbcAFPgY (ORCPT ); Wed, 6 Jan 2016 10:36:24 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:49343 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751761AbcAFPgU (ORCPT ); Wed, 6 Jan 2016 10:36:20 -0500 Message-ID: <568D3452.80508@huawei.com> Date: Wed, 6 Jan 2016 15:35:46 +0000 From: Salil Mehta User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: David Miller , CC: , , , , , , Subject: Re: [PATCH] net: hns: avoid uninitialized variable warning: References: <6649249.INrAY8KJG0@wuerfel> <20160105.164320.2255971055498857833.davem@davemloft.net> In-Reply-To: <20160105.164320.2255971055498857833.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.154] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.568D3469.02B9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: d27ae2ae8575568b89a6559874983a4a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/5/2016 9:43 PM, David Miller wrote: > From: Arnd Bergmann > Date: Fri, 01 Jan 2016 23:27:57 +0100 > >> gcc fails to see that the use of the 'last_offset' variable >> in hns_nic_reuse_page() is used correctly and issues a bogus >> warning: >> >> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function 'hns_nic_reuse_page': >> drivers/net/ethernet/hisilicon/hns/hns_enet.c:541:6: warning: 'last_offset' may be used uninitialized in this function [-Wmaybe-uninitialized] >> >> This simplifies the function to make it more obvious what is >> going on to both readers and compilers, which makes the warning >> go away. >> >> Signed-off-by: Arnd Bergmann >> --- >> Compile-tested only, and complex enough that this requires a proper >> review and testing before it gets apply. Please have a look at this. > If this goes yet another day without being reviewed, I'm just applying > it. > > You hisilicon folks can't just let patches rot, you must review them > in a timely manner or else I'm applying them without waiting for you > to look at them. Hi David and Arnd, Apologies for the delay in response and the review. Most of us were on the Annual Holidays and have just returned back. Change looks good to me! Best Regards Salil