From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbcAFRfu (ORCPT ); Wed, 6 Jan 2016 12:35:50 -0500 Received: from www.sr71.net ([198.145.64.142]:36103 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbcAFRft (ORCPT ); Wed, 6 Jan 2016 12:35:49 -0500 Subject: Re: [PATCH 3/5] x86: simplify early command line parsing To: Borislav Petkov References: <20151222225237.08CDE5F1@viggo.jf.intel.com> <20151222225241.15365E43@viggo.jf.intel.com> <20160106171044.GB20321@pd.tnic> Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, fenghua.yu@intel.com, yu-cheng.yu@intel.com From: Dave Hansen Message-ID: <568D5073.8070400@sr71.net> Date: Wed, 6 Jan 2016 09:35:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160106171044.GB20321@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2016 09:10 AM, Borislav Petkov wrote: >> > diff -puN arch/x86/lib/cmdline.c~x86-early-command-line-non-term arch/x86/lib/cmdline.c >> > --- a/arch/x86/lib/cmdline.c~x86-early-command-line-non-term 2015-12-22 11:56:59.454186167 -0800 >> > +++ b/arch/x86/lib/cmdline.c 2015-12-22 11:56:59.457186302 -0800 >> > @@ -39,9 +39,6 @@ int cmdline_find_option_bool(const char >> > if (!cmdline) >> > return -1; /* No command line */ >> > >> > - if (!strlen(cmdline)) >> > - return 0; >> > - > Patch 1 adds the strlen(), this patch removes it. Please merge both patches. Yes, it adds a line that uses strlen. But, there was already the use in the min_t() "call": > - len = min_t(int, strlen(cmdline), COMMAND_LINE_SIZE); > - if (!len) > + if (!strlen(cmdline)) > return 0; I wanted to separate the two things because they really fix two separate issues. I also want to ensure that any problems that this patch causes can be isolated to the smallest change possible.