From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbcAGUjf (ORCPT ); Thu, 7 Jan 2016 15:39:35 -0500 Received: from mout.web.de ([212.227.17.11]:57617 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbcAGUj1 (ORCPT ); Thu, 7 Jan 2016 15:39:27 -0500 Subject: Re: net-thunder: One check less in nicvf_register_interrupts() after error detection To: Joe Perches References: <566ABCD9.1060404@users.sourceforge.net> <5685A273.6070607@users.sourceforge.net> <20160107110701.GE25086@rric.localdomain> <568EBCE7.4060502@users.sourceforge.net> <1452195846.4028.24.camel@perches.com> <568EC2FD.9000702@users.sourceforge.net> <1452196790.4028.33.camel@perches.com> <568EC56A.402@users.sourceforge.net> <1452198530.4028.43.camel@perches.com> Cc: Robert Richter , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sunil Goutham , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568ECCD3.1020700@users.sourceforge.net> Date: Thu, 7 Jan 2016 21:38:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1452198530.4028.43.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3S01VENkXopEXIf8QccCkAJLcovfS9plKsdL1PWXsHFmD/Uuj9G dDV5Whv/b6p4aha+u7yX6wyWp2KwfiBc9t7PNY11Bfod4mhpn59BkVxN5/YAyt0FS1vL3Kn guyhUqY1g0p3AvQBSqRdWTMv1pPS64Ha1woBmCPGX+NfM6u0aP4CsAWBZv2yjlwF0KZqIR7 SiU3ZQUzq4IzogudG157A== X-UI-Out-Filterresults: notjunk:1;V01:K0:lE0o98MgZUU=:TsBY2EyGCsue8T3pOWlMBr 2bNQ4vSZBILPDEj4CkWvIru24x/da0mu3c76uJauxFjyDPDnT8Du14vf0LOCvN6ra9LLGe+zA DB5IpU0RITwlYLhqwodihKz3yvrxTbc+9xf2Kk/8sFSGy9PrxD/OgOIekDjYxpFq7w1O1q5d7 REnzCYKbCQXinghkTBh5zFXafZp1qG8JiHdnyfMq0qJvt47tRsrEO4V4H7LM4fjvYZtxgWIgV clCQNbD9Wsd+LxuMVj8YSvGwk7f2WgpYuH/4mt77hOTopuyvUgdeP6ByzMwRQMuJNFAziFRfF lG98tMVBcY0PAPZSR2jYL08y2Ys28RslzlrFsyqBI9PPq8h1zruy6cmvJUjtho8h/v2Z6Xhq/ 6DK/EeMcd/LTi/ExoBS+Op4E3/OSa8ykKTGJHkVCUMlJu6foa1MXHazy5XkDtYcTEJGr472iG rc/RRMvp0HuY1UQG3Uqqf29UaKaUXB6ml1eLqG6b+5kpYSzEXQL4P+iwEcPbJ2oPcbgk5mWH9 BDzl7HspQzJd30Hiez2YnPNpK0GRkohu9JX4wTDE5x213xQKrwWEUMlpo+m2Ri8J3vb/2GDpm 0TwGMvAoMRsLvo5Y0iDo8I0IqcL3AVOrW8Dchw9IianJE0c5iCBYrKHd1uCJsiGASsFdgF7Ur zs5yY9lgvyhwTXzm4s/iEK41gpYpwfV/I4z52s1Zn6ySDgAdlZqTzC9JuL7G8j/Ilv1+KGGD7 bV8ICP3PEkAiv30J8RV+kzm15NMq2vRUh5p8hBTxEEYyu6zxHh7lEJS+rhbvY11GzyLeRbJMs +Q0qK7O Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Some prefer that source code be "templatized" regardless > of the number of exit points that any particular use of a > specific function type. This is another interesting view on involved implementation details. > Some of your patches are converting these templatized > functions to a different form for no added value. Would you like to distinguish a bit more between my evolving collection of update suggestions and the concrete proposal for the function "nicvf_register_interrupts"? > These patches make the local source code inconsistent > and generally goes against the authors preferred style. Which programming approach will be the leading one here finally? Regards, Markus