From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbcAHJ0a (ORCPT ); Fri, 8 Jan 2016 04:26:30 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34086 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751397AbcAHJ01 (ORCPT ); Fri, 8 Jan 2016 04:26:27 -0500 Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out To: Heiko Stuebner References: <1452155155-16232-1-git-send-email-wxt@rock-chips.com> <1452155155-16232-5-git-send-email-wxt@rock-chips.com> <290434099.8XFZ9qmNRz@phil> Cc: Caesar Wang , Ulf Hansson , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, leecam@google.com, linux-arm-kernel@lists.infradead.org, keescook@google.com, linux-clk@vger.kernel.org, leozwang@google.com From: Caesar Wang Message-ID: <568F80BA.6060209@gmail.com> Date: Fri, 8 Jan 2016 17:26:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <290434099.8XFZ9qmNRz@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Heiko, 在 2016年01月07日 18:05, Heiko Stuebner 写道: > Hi Caesar, > > Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang: >> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by >> extra codecs. >> >> Due to it shouldn't belong to any driver, but we need it enabled, >> so just mark it as the CLK_IGNORE_UNUSED flag. > What makes you think it shouldn't belong to any driver? > > In most schematics I have, i2s_clkout is going to some clock-input of the > audio codec - probably the MCLK input on your rt5616. And while the new > rt5616 driver does not seem to do clock handling, it should just handle the > clock using the normal APIs. You are right, that's seem has to find the root cause. I'm wonder that the codec/i2s is working in kernel v4.1 patch without it. In general, the MLCK will be handled in i2s driver if the cpu side is master. > > > Heiko > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar