From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbcAHMBD (ORCPT ); Fri, 8 Jan 2016 07:01:03 -0500 Received: from mout.web.de ([212.227.17.12]:52864 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754785AbcAHMA7 (ORCPT ); Fri, 8 Jan 2016 07:00:59 -0500 Subject: Re: 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() To: Ursula Braun References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F198.4040109@users.sourceforge.net> <1452177226.1081.6.camel@BR9GV9YG.de.ibm.com> <568F62D0.9050806@users.sourceforge.net> <1452241551.5327.16.camel@BR9GV9YG.de.ibm.com> Cc: linux-s390@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568FA4F2.1000200@users.sourceforge.net> Date: Fri, 8 Jan 2016 13:00:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1452241551.5327.16.camel@BR9GV9YG.de.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:EK5LjMRiT9kjKT4qlJMbEuuwKXKzs7OGfUB1thkpt+F+pBUm1Um LD5QMXiOgcjHYl8KJz6d9Qr4YrJAzxD+R1y9pIUuFk8kZ0hMapQQvY0wBkzeUKbcTMRfvlu uKENbZc7V7b43h58OxIsDB7PUKAV6wCI2Bbf0UM7xGjLt97ten6myTRdNgFFFRx0fOYWgEr 6lWkAZjp/ryIJ3Pvtl/bg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ERxP74wn5og=:ZQCDbXaDm5qOGwAG6ZOf8q Zk28R3T7MC7ou6zRCtWyPKD3Y/k4CPuRE/6SQFHFUvUp7H3p4flceLpzLSIxDHOPPhVJYVCs6 ESGp3u0pHOlKag77CO+WX76KOJ8V0Hw1riZkHfvhLJWvDdcyncPUCEQ85x1y9AtmVu8lfNggy 3u79msRHHR7ppdwqL9SSgCV/FLF4EvHqrxPvrmchWD9egWauo9315Olkc5YsUqQxGYJ0RXr+X Jqh2fK2m6duro5v0Wp2FhENG9EmfBfgdGm8McV2XpN1Axt8pJVbgvJqdMCmhrjfIW9s3UxccC WB8FQz7Uj+faK2pDPRX1y7lTVaOZ+dWQSe13CWvOYiz+x48QCov9hHgOEvpMCmNBeUxLro6Mg bklMVuOf1YEi5EXNYUSbsJJGEPsYueGvnqtlg1ZLbz4QVhcZ7VODXZn4D8MzbuoOuiEYmHiQA 6qOPKT0FDBNjFi+q1IDa5BEF80QGDpt6puQKEtlzle7W2oaDYYZ7NnzXJcwzfP/TBstKs2PxI q8hhuaM547nI537KS2Tm4AdDkesm1YoDF7b0AruprFsm77FSF5MZa3li+KSO2RsJxU4DHBeSt 1HWH3BMc8LQWwdTQTwadTkpyC14EwTddka2U9nvheee0mWnsFg/tcvrmaqiMM4Ylvkta7T56f NMUKkaOHknzTckpSz4jSPEDO4m4jc8gnYhbX02HalMUAdYQTDLNIghDbkzyjsD+nDGImx/Lx/ s9QBBRGkNRXYslZFRMOgcjPvIFq1uktIj12zX+zTu523hJneRftzKsFicvS9guLLNGvCM3aD5 JBgWBI7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Is there any more fine-tuning cooking in the background? > Not yet; I am a bit surprised by this information. > qeth is an important driver for Linux on System z; Good to know … > there are lots of investigation ideas for improvements, > which we will take care about according to their priorities. Software development as usual … > I regard your proposed fine-tuning code change as valid, Thanks for a bit of positive feedback. > but prioritize it as one with lowest benefit, This is fine in principle. > since it does not really make a difference once compiled. Would you like to help in the determination if deletion of unnecessary variable initialisations (besides in the implementation of the function "qeth_core_set_online") will result in measurable effects? Regards, Markus