From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754678AbcAHMNu (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2016 07:13:50 -0500
Received: from lists.s-osg.org ([54.187.51.154]:49275 "EHLO lists.s-osg.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754370AbcAHMNs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2016 07:13:48 -0500
Subject: Re: [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for
 the simple power sequence
To: Caesar Wang <wxt@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>,
        Ulf Hansson <ulf.hansson@linaro.org>
References: <1452155155-16232-1-git-send-email-wxt@rock-chips.com>
 <1452155155-16232-6-git-send-email-wxt@rock-chips.com>
From: Javier Martinez Canillas <javier@osg.samsung.com>
X-Enigmail-Draft-Status: N1110
Cc: linux-rockchip@lists.infradead.org, leecam@google.com, leozwang@google.com,
        keescook@google.com, devicetree@vger.kernel.org,
        Andreas Fenkart <afenkart@gmail.com>,
        Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>
Message-ID: <568FA7F3.9090304@osg.samsung.com>
Date: Fri, 8 Jan 2016 09:13:39 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1452155155-16232-6-git-send-email-wxt@rock-chips.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Caesar,

On 01/07/2016 05:25 AM, Caesar Wang wrote:
> This patch adds the exteral vcc optional for the simple power sequence.
> 
> Some WLAN chips attached to a SDIO interface, need an external vcc
> to be operational. Since this is very common, extend the simple MMC
> power sequence DT binding to support an optional exteral vcc.
> 

s/exteral/external in the subject line and other places.

I think that makes sense to extend the simple power sequence provider
to add a regulator since many SDIO chips may needed it but it seems
from the commit message of patch 06/12 that you don't actually need
a regulator but to toggle a WL_REG_ON pin in your WiFi chip.

I'll answer to that patch though.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America