From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758238AbcAKE0g (ORCPT ); Sun, 10 Jan 2016 23:26:36 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:18242 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757979AbcAKE0f (ORCPT ); Sun, 10 Jan 2016 23:26:35 -0500 Message-ID: <56932EE9.2030909@huawei.com> Date: Mon, 11 Jan 2016 12:26:17 +0800 From: wanghaibin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Tejun Heo CC: , , Subject: Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed. References: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com> <1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com> <20160107155032.GB1898@mtj.duckdns.org> In-Reply-To: <20160107155032.GB1898@mtj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.144] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.56932EF3.0059,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 723ccaf58b13ce29a5c2add104bbb52c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/7 23:50, Tejun Heo wrote: > On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote: >> Before the return that wq_numa_init failed, it will be bettet to free >> the numa node table to avoid the memory leaks. > OK, I just expect that it can free the memory in all exception cases! > That's a WARN_ON condition which should never happen. The system is > already pretty messed up and just limping along. It really doesn't > matter whether some memory is cleaned up or not. Let's keep it > simple. OK, get it ! > > Thanks. >