From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758975AbcAKJ40 (ORCPT ); Mon, 11 Jan 2016 04:56:26 -0500 Received: from foss.arm.com ([217.140.101.70]:53819 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757704AbcAKJ4Y (ORCPT ); Mon, 11 Jan 2016 04:56:24 -0500 Subject: Re: [PATCH v4 2/2] mm/page_alloc.c: introduce kernelcore=mirror option To: Andrew Morton References: <1452241523-19559-1-git-send-email-izumi.taku@jp.fujitsu.com> <1452241613-19680-1-git-send-email-izumi.taku@jp.fujitsu.com> <568FEBAF.9040405@arm.com> <20160108151223.a9b7e9099de69dbe6309d159@linux-foundation.org> Cc: Sudeep Holla , Taku Izumi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, tony.luck@intel.com, qiuxishi@huawei.com, kamezawa.hiroyu@jp.fujitsu.com, mel@csn.ul.ie, dave.hansen@intel.com, matt@codeblueprint.co.uk, arnd@arndb.de, steve.capper@linaro.org From: Sudeep Holla Organization: ARM Message-ID: <56937C44.9040707@arm.com> Date: Mon, 11 Jan 2016 09:56:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160108151223.a9b7e9099de69dbe6309d159@linux-foundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/16 23:12, Andrew Morton wrote: > On Fri, 8 Jan 2016 17:02:39 +0000 Sudeep Holla wrote: > >>> + >>> + /* >>> + * if not mirrored_kernelcore and ZONE_MOVABLE exists, >>> + * range from zone_movable_pfn[nid] to end of each node >>> + * should be ZONE_MOVABLE not ZONE_NORMAL. skip it. >>> + */ >>> + if (!mirrored_kernelcore && zone_movable_pfn[nid]) >>> + if (zone == ZONE_NORMAL && >>> + pfn >= zone_movable_pfn[nid]) >>> + continue; >>> + >> >> I tried this with today's -next, the above lines gave compilation error. >> Moved them below into HAVE_MEMBLOCK_NODE_MAP and tested it on ARM64. >> I don't see the previous backtraces. Let me know if that's correct or >> you can post a version that compiles correctly and I can give a try. > > Thanks. I'll include the below and shall add your tested-by:, OK? > Yes this is the exact change I tested. Also I retested your latest patch set with today's -next. So, Tested-by: Sudeep Holla -- Regards, Sudeep