From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760690AbcAKPTB (ORCPT ); Mon, 11 Jan 2016 10:19:01 -0500 Received: from mail5.windriver.com ([192.103.53.11]:45331 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760632AbcAKPS7 (ORCPT ); Mon, 11 Jan 2016 10:18:59 -0500 Message-ID: <5693C756.8010108@windriver.com> Date: Mon, 11 Jan 2016 10:16:38 -0500 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Manjeet Pawar , , , , , , , CC: Subject: Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. References: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com> In-Reply-To: <1452502945-27765-1-git-send-email-manjeet.p@samsung.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-01-11 04:02 AM, Manjeet Pawar wrote: > This patch enable network driver support for ARM64 Your commit log only repeats what is obvious from the one line change itself. It might be nice to indicate what platform it was validated on, what tests were run and what features of the driver were exercised (multicast, netpoll, ...) Imagine if I sent you a similar patch where I added MIPS and said nothing more than "enable network driver support for MIPS" and Cc'd you expecting you to comment on whether it was OK. Thanks, Paul. -- > > Signed-off-by: Akhilesh Kumar > Signed-off-by: Manjeet Pawar > --- > drivers/net/ethernet/smsc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig > index eb9230e..6e73c73 100644 > --- a/drivers/net/ethernet/smsc/Kconfig > +++ b/drivers/net/ethernet/smsc/Kconfig > @@ -77,7 +77,7 @@ config SMC911X > tristate "SMSC LAN911[5678] support" > select CRC32 > select MII > - depends on (ARM || SUPERH || MN10300) > + depends on (ARM || ARM64 || SUPERH || MN10300) > ---help--- > This is a driver for SMSC's LAN911x series of Ethernet chipsets > including the new LAN9115, LAN9116, LAN9117, and LAN9118. >