From: "Wangnan (F)" <wangnan0@huawei.com>
To: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, "Ingo Molnar" <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable
Date: Tue, 12 Jan 2016 17:28:28 +0800 [thread overview]
Message-ID: <5694C73C.3070007@huawei.com> (raw)
In-Reply-To: <1452509693-13452-7-git-send-email-jolsa@kernel.org>
On 2016/1/11 18:54, Jiri Olsa wrote:
> Introducing FEATURES_DUMP make variable to provide features
> detection dump file and bypass the feature detection.
>
> The intention is to use this during build tests to skip
> repeated features detection, like:
>
> Get feature dump static build into /tmp/fd file:
> $ make feature-dump FEATURE_DUMP_COPY=/tmp/fd LDFLAGS=-static
> BUILD: Doing 'make -j4' parallel build
>
> Auto-detecting system features:
> ... dwarf: [ OFF ]
>
> SNIP
>
> FEATURE-DUMP file copied into /tmp/fd
>
> Use /tmp/fd to build perf:
> $ make FEATURES_DUMP=/tmp/fd LDFLAGS=-static
>
> $ file perf
> perf: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), statically linked, for ...
>
> Suggested-by: Wang Nan <wangnan0@huawei.com>
> Link: http://lkml.kernel.org/n/tip-fhb47m6t18txuwrzu33is2bo@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
Thank you for these two patch. However I found a small limitation.
I must skip 'make clean' between two feature-dump, or the result is wrong.
For example:
$ make feature-dump LDFLAGS="-static"
BUILD: Doing 'make -j24' parallel build
Auto-detecting system features:
<SNIP>
... zlib: [ on ]
... lzma: [ OFF ] <--- looks good. I don't
have static lzma library
... get_cpuid: [ on ]
... bpf: [ on ]
$ make feature-dump
BUILD: Doing 'make -j24' parallel build
Auto-detecting system features:
<SNIP>
... zlib: [ on ]
... lzma: [ on ] <--- also good
... get_cpuid: [ on ]
... bpf: [ on ]
$ make feature-dump LDFLAGS="-static"
BUILD: Doing 'make -j24' parallel build
Auto-detecting system features:
<SNIP>
... zlib: [ on ]
... lzma: [ on ] <--- Bad...
... get_cpuid: [ on ]
... bpf: [ on ]
Thank you.
next prev parent reply other threads:[~2016-01-12 9:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 10:54 [PATCH 0/6] tools: Add clean targets for tools directory Jiri Olsa
2016-01-11 10:54 ` [PATCH 1/6] " Jiri Olsa
2016-01-12 10:06 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 2/6] tools bpf: Add *.cmd files clean up Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 3/6] tools lockdep: " Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2016-01-11 10:54 ` [PATCH 4/6] perf tools: Add missing sources in perf's MANIFEST Jiri Olsa
2016-01-12 10:07 ` [tip:perf/urgent] perf tools: Add missing sources to perf' s MANIFEST tip-bot for Jiri Olsa
2016-01-11 10:54 ` [RFC 5/6] perf build: Add feature-dump target Jiri Olsa
2016-01-11 10:54 ` [RFC 6/6] perf build: Introduce FEATURES_DUMP make variable Jiri Olsa
2016-01-12 9:28 ` Wangnan (F) [this message]
2016-01-13 9:19 ` Jiri Olsa
2016-01-13 9:46 ` Wangnan (F)
2016-01-13 10:03 ` Jiri Olsa
2016-01-13 10:11 ` Wangnan (F)
2016-01-13 12:02 ` Wangnan (F)
2016-01-13 12:15 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5694C73C.3070007@huawei.com \
--to=wangnan0@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).