From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965238AbcALL2Y (ORCPT ); Tue, 12 Jan 2016 06:28:24 -0500 Received: from mout.web.de ([212.227.15.3]:57131 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965203AbcALL2V (ORCPT ); Tue, 12 Jan 2016 06:28:21 -0500 Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe() To: Lee Jones References: <566ABCD9.1060404@users.sourceforge.net> <5682957F.5000604@users.sourceforge.net> <56829630.6030706@users.sourceforge.net> <20160111081059.GS3331@x1> <20160111081219.GT3331@x1> <5694BE21.3010504@users.sourceforge.net> <20160112090532.GS19803@x1> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5694E34D.9010609@users.sourceforge.net> Date: Tue, 12 Jan 2016 12:28:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160112090532.GS19803@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:phe7EquPIplKuvAlGMRkP7xgYWA+vTPWyCdN+uDY3btMLex9z6f LMZio4GXCfK8qM2QcWdvbXGD0P350ZmCqZdIsAGH4RwmUajiq5agjP4VhC49YZ6qG+l/IdF i37cGXguQyZxEjyNRBYJ5CcdhgS9AHjKs7o/6rCMMlVcZcE0YPQtqZioNYHfk7Sp4FA2lft 3e8IP5voUDZwJZGn/xi+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:S1Bfm9WZ9pY=:Nyi7ynDL53CtiI5muVn644 YQ/txMmJjTbD/qCs2ETh0fzjteMt86xZuxUTAntt5cQhOXRaxjHW9hbXq9IRWO5CwyOVj8901 WN9/GqAjkYnCNAZSM+uCeuwc29cWzyrwKXGv/kq0bZQLdH9Uhk/mnXO3VwIzmt5W7qKqDNDJ8 rCZY3WVb+/mTHTQSu4o59CEWH9bdIo7OXX50zG0fIqzSFN2q2c3yGTNKjp/uUu2ieJawY385c ftP0WEx4Fyajfm954DBsVAqOqU2Tu7V9qAk3OIotpGqmxxFVK03wjDWAtDMYih+PtT70nUHRC dPDlq9N3rM3zOgiDy6NcRF4jlAUmKEAdouedj+HrryYVwPtunM1vEkf3L4gnDbzI9k6eVXCbJ 718n+IS+TjpIeG29xGodf9SSELKNIOWO/yp6oO6h4CtQ7qBeCF/TxJWVudoRv8I3/Yoc16a4i Em9xg44NLuH8uenYD8H96sL1Dy8gwH4vlICEtwJ2U7lnKTMq8WXz1SkEJOK3D0jSNtvFgHBuI RwfLG3UsiQE+ZyqjnYXEcZ5PW6LxZGOQKvZL4kGE9CTabQqoUE6W7zEigvDwb2OEMVR3Z2ElH rUJfXsWr5cBDAMdsBqlPRHkgARBxlOxyrLJkxnsQQnrbEcCrhG1dNght+mSIjPPXluqZzjTOr wDgZFX/2pvFHF6+iZ96l7Aog3knmnX66z4FGabC5lAqEBWbFn6XKB1fuFTxWAlnx4u9zSpRhj +L3vCv1BYcMf0uI373hPWotCaMVgm40zZHt3vABu8+z7lBhZ+KIsTjuBDwqLjMDOQDOv8KUXY PbR1I57 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Which topic would you prefer for my update suggestion instead? > > This one. > > "mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()" > > The function name and just describing the changes as "refactoring" do > not describe the changes in a helpful way. Would you find a subject like "mfd: smsc-ece1099: Better exception handling in smsc_i2c_probe()" acceptable? >>>> Acked-by: Lee Jones >> >> Do you really request that I should append this tag already to messages >> for (my adjusted) commits you can not see so far? > > Yes. Interesting … > The code looks fine, Thanks for a bit of positive feedback. > and if the commit log is still not up to scratch I just won't apply it. :) Can we eventually agree on an useful message before I would dare another commit? Will it be sufficient to delete the asterisks there? Regards, Markus