From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762193AbcALMUn (ORCPT ); Tue, 12 Jan 2016 07:20:43 -0500 Received: from mout.web.de ([212.227.15.14]:61275 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbcALMUl (ORCPT ); Tue, 12 Jan 2016 07:20:41 -0500 Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after error detection To: Lee Jones References: <566ABCD9.1060404@users.sourceforge.net> <568284D3.3060006@users.sourceforge.net> <20160112115906.GD27358@x1> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5694EF91.70609@users.sourceforge.net> Date: Tue, 12 Jan 2016 13:20:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160112115906.GD27358@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:aAXwWCa7d/lwKHnQjMZ3nya8rHXM6fa3MmHd3+V/GUDgAg/eKba Gr5ttJ0TVHpcZhn2NiAzMC9ne8x/bJQFj77+MfHMJf3jvJQlsSd90GVd9r+sa0EBGa4BJqD c/htVYMNhV1KQJsSjgP5qx7Oxwlp5MZVFmIYBROYXE7m3+HbsCA5KaGsRuGGmjp8xAnBg1b PIVa88oxyv1FFarZKt/KA== X-UI-Out-Filterresults: notjunk:1;V01:K0:HhUPM+FVjxg=:i/gyC9xjyuK4Do6sO+zRrp WWkrmXlK9W2KykPkgha448SGlAPgWcRRBdPcdwGWEv/eUulc4KA5lUJEpBWdVQup0rL9+WYkR jq85eVJHMtRB+SY6CiPyHPRn/W2BLxUrWXVTGhBItbE56sN0JF9JQbTiRpyueUiGwX9CITiD1 ILVMocb6IOAP3xZ2NZko+rYN66LwmEuFAv00IpkgUM8Y/Krenp6QRzPi4D9kM8UudnnN295zV MxEsnbh8gRonor79JyYHQWpM9m6dbQT8fizoYAAw6fuP6ddPSeHMBkIWGE9Hpy/q0Z/2A3XFB 9XNQiY7q47C0vazjlmb0/tMKLHdgDdQifk/oQ5UEtZ8iBxcnWWhdwKc5QzKepyjCmIo3HwLwC 7gfkKG43Y7pKXuyqc32xI78WWnTI1dH9HAckoXvIj43E5m00T5WlmpOzcSwhMtASklYJnBSAT 7IerDI9dlEhWOX+f66KZVCvcvFE2dTEq+c8qoFhWYBiMQCSkWl1Pgyox4/Y6so1WPb7L3IGj7 uD/KU8+xJSZgzEO0DW704DU6llhIM0DDxsgHdTMcfVxXL0FAOMOxrja7H1AJRF4tbVE+N+5WT Xlg/g+gsMOs3doFmP3TqisKkXF4MJ/VYXgZ5z4uZWSFB5/dstqU9WhjeXwJiJHl1YZOsWASQz pNz4HUwnJry5xa936XydVGW0Eg+MZ4sioDbUSAgKf68zndedri2wIQc/699ATLSdiy7XsPKIU JwLA0nH9RM8uuGaKV0zWOvY8cxWLKjc3qrrnCs1D9PvUXzlifkAJglIkB1Quhe/ysUEbnQ+Ab gBhN/My Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The subject format is wrong Which format do you expect? > and the summary itself isn't very informative. Which wording do you find more useful? >> From: Markus Elfring >> Date: Tue, 29 Dec 2015 13:56:42 +0100 > > This patch format is wrong, You might find the use of additional fields in the message body unusual. I have got an other impression from the canonical patch format. > please consider using `git format-patch` and `git send-email`. Thanks for your suggestion. >> The platform_device_put() function was called in one case by the >> add_child() function during error handling even if the passed >> variable "pdev" contained a null pointer. >> >> Implementation details could be improved by the adjustment of jump targets >> according to the Linux coding style convention. I am going to integrate the source code changes that you requested a bit later. >> +report_failure: >> + dev_err(&client->dev, "can't add %s dev\n", name); > > This isn't a very friendly error message. Better to convert the > dev_dbg() calls to dev_err() and tell the user what the problem was. Which information display would be more appropriate here? Regards, Markus