From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753468AbcAMBwq (ORCPT ); Tue, 12 Jan 2016 20:52:46 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36053 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbcAMBwo (ORCPT ); Tue, 12 Jan 2016 20:52:44 -0500 Subject: Re: [PATCH V2 03/10] irqchip,GICv3,ACPI: Add redistributor support via GICC structures. To: Tomasz Nowicki , Marc Zyngier , tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, guohanjun@huawei.com, Suravee.Suthikulpanit@amd.com References: <1450353133-15992-1-git-send-email-tn@semihalf.com> <1450353133-15992-4-git-send-email-tn@semihalf.com> <5694EB92.9030109@arm.com> <56952DA1.4030401@semihalf.com> Cc: mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com From: Hanjun Guo Message-ID: <5695ADE5.7010501@linaro.org> Date: Wed, 13 Jan 2016 09:52:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56952DA1.4030401@semihalf.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/13 0:45, Tomasz Nowicki wrote: > On 12.01.2016 13:03, Marc Zyngier wrote: > > > + typer = readq_relaxed(redist_base + GICR_TYPER); > > + /* don't map reserved page as it's buggy to access it */ > > + size = (typer & GICR_TYPER_VLPIS) ? SZ_64K * 3 : SZ_64K * 2; > > [...] > >> Also, please map the whole region for the >> redistributor as we have on the DT side (4 64kB pages for VLPIS capable >> redistributors). > > Hanjun, is it something you had problem with? Yes, for D02, it use 3 64kB pages for GICv4, it removed the reserved page. In DT case, it has "stride" binding so it can support no standard cases, seems that we can introduce "stride" for ACPI too. Thanks Hanjun