From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757137AbcAOLfA (ORCPT ); Fri, 15 Jan 2016 06:35:00 -0500 Received: from mout.web.de ([212.227.15.3]:50263 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755200AbcAOLep (ORCPT ); Fri, 15 Jan 2016 06:34:45 -0500 Subject: Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() To: Dan Carpenter , netdev@vger.kernel.org References: <566ABCD9.1060404@users.sourceforge.net> <56866E7F.8080609@users.sourceforge.net> <5698C53C.8060204@users.sourceforge.net> <5698C61A.90504@users.sourceforge.net> <20160115102947.GI4764@mwanda> Cc: Claudiu Manoil , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5698D949.6000404@users.sourceforge.net> Date: Fri, 15 Jan 2016 12:34:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160115102947.GI4764@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Ka3R8Oheki+7nGrOEZptds8haM6ul/h1irpbUMd74uBek4j+nMN zGBXLUV8mP4SmXIMKj82GrcH7I0jwdVNFSes/jxrYfNc+jcs77HM3X+nY6VuxYyypYPvk+B rKjKY6TWDVXF6d1fD6C0d7EP4frZYqIsgylVNPKCqGb5Ig5/vKXinkDMpiTIQ0C/htRyZyW YV9rp5jvqUvjBtAWXmIPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MIPBAq4zgaA=:iYDLQoZhgoDuK3WTzvag1h sP8Fg+wgM/r1ZDgAGQ1iJ5+7OshSNV/1IgxuI5OTt5qDyJVr4S7YABlEm8hg7zgW2Q/H01h/7 1CfZJIjXkleOLxcF8eJ1m61ghD6bye+r8mgVQdNLN5BRw+3hP/hc86HVRnRPYgxwwy4e6mbv6 1hRXA7TGqkCbaaFjPMyYRUA0vzreY1LobBViCvJ/Coi1jNM4kareUg+NbkC7Mqkc9xyAQ6Ubr x1r2wr1WaCAZSWpcOIaLn6F07wvXcRo+3Dd5X3f2o8sqmQSV0SidH2RookEsdDl2NLv2ZBKJV Okyi+dgx2JbEfOKcYjcbglzKQjHwRkA/ndB1vKW0fwW0rWcpjdQ431qbBvytxykoxUFPRwxP4 IXqYWnzA4esCma2xXbu6Lsfbg4fSG7WS2SddQ2MsKmPO2RqwZQjBe9PPzvljRRHNDRU8zQ2Rw yKNq0/BoidSo2UG3R0het7ue01nbqx+EkdimCSYawOSEcaLvmzgr2hVR3YBtzOdOTexKl2a8l Lc7TR7drGeHP0CtuYzwP7ce2pwzx9sY9GchKjsDEIdRsH81WAwSQ+dfLEjGi68yMnn/QmSw+0 +LHNQ6rKhT4VpX4MV5AqfzsI82MO0hMIv/cOAJgqpv0u1eSab1HntSUTZ3oHuPKNdFS3Sg07d SxB1DKlkNAgORVjv/ClV5qTinFw3QKuHrxEocxVLarZLRwsmzya8Wz08bqhyTQhJvs0tkGAh/ qcExJbcevCWBRZlEfRYnO0ERrpj6CWZmWLyCFlMvPo3brerfVdCxHkiE9THiFgyGfSTNLkkCp 3hjeMIi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c >> @@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) >> static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, >> u64 class) >> { >> - unsigned int last_rule_idx = priv->cur_filer_idx; >> + unsigned int last_rule_idx; > > This is a write only variable. We can just remove it. Can a static source code analysis tool like the software "http://smatch.sourceforge.net/" detect that such a variable is not read by this function implementation so far? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/freescale/gianfar_ethtool.c?id=b75ec3af27bf011a760e2f44eb25a99b6fbb0fb3#n850 Does this place indicate an unwanted value assignment as a leftover, or are there any other actions missing? Regards, Markus