From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964859AbcATRa4 (ORCPT ); Wed, 20 Jan 2016 12:30:56 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:60767 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934015AbcATRay (ORCPT ); Wed, 20 Jan 2016 12:30:54 -0500 Subject: Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional To: =?UTF-8?Q?Lothar_Wa=c3=9fmann?= , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown , Mark Rutland , Pawel Moll , Rob Herring , Russell King , Tony Lindgren , , , , References: <1453292992-1788-1-git-send-email-LW@KARO-electronics.de> <1453292992-1788-2-git-send-email-LW@KARO-electronics.de> From: Grygorii Strashko Message-ID: <569FC40B.5030902@ti.com> Date: Wed, 20 Jan 2016 19:29:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453292992-1788-2-git-send-email-LW@KARO-electronics.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2016 02:29 PM, Lothar Waßmann wrote: > On the AM335x SoC rev. <= 1.0 the "Input Function of the EXTINTn > Terminal is Inverted", for which the only remedy is to "Use an active > high interrupt source or use an external inverter to change the > polarity of any active low interrupt source." > > This pin is used as IRQ pin for the LTC3589 PMIC on the Ka-Ro > electronics TX48 module. Make the IRQ optional in the driver and use a > polling routine instead if no IRQ is specified in DT. > Otherwise the driver will continuously generate interrupts and make > the system unusable. > > Signed-off-by: Lothar Waßmann > --- > drivers/regulator/ltc3589.c | 49 +++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 45 insertions(+), 4 deletions(-) > > diff --git a/drivers/regulator/ltc3589.c b/drivers/regulator/ltc3589.c [...] > } > @@ -519,6 +539,16 @@ static int ltc3589_probe(struct i2c_client *client, > return ret; > } > } > + if (client->irq <= 0) { > + dev_warn(dev, > + "No interrupt configured; poll for thermal shutdown and undervoltage events\n"); > + > + INIT_DELAYED_WORK(<c3589->poll_timer, ltc3589_poll_func); > + schedule_delayed_work(<c3589->poll_timer, > + msecs_to_jiffies(POLL_PERIOD)); > + > + return 0; > + } > > ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr, > IRQF_TRIGGER_LOW | IRQF_ONESHOT, ^^^^^^^^^^^^^^^^ I assume you have issue with IRQ because of the above hard-coded flag. if yes - Over all approach for such kind of issues - do not hard-code IRQ triggering flags in code in case of DT boot. DT core will configure it properly. [...] -- regards, -grygorii