From: Vlastimil Babka <vbabka@suse.cz>
To: Dave Hansen <dave@sr71.net>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
aarcange@redhat.com, n-horiguchi@ah.jp.nec.com, jack@suse.cz
Subject: Re: [PATCH] mm, gup: introduce concept of "foreign" get_user_pages()
Date: Wed, 20 Jan 2016 20:30:49 +0100 [thread overview]
Message-ID: <569FE069.6080205@suse.cz> (raw)
In-Reply-To: <20160120173504.59300BEC@viggo.jf.intel.com>
On 01/20/2016 06:35 PM, Dave Hansen wrote:
> Here's another revision taking Vlastimil's suggestions about
> keeping __get_user_pages_unlocked() as-is in to account.
> This does, indeed, look nicer. Now, all the "__" variants
> take a full tsk/mm and flags.
>
> He also noted that the two sites where we called gup with
> tsk=NULL were probably incorrectly changing behavior with respect
> to fault accounting. Long-term, I wonder if we should just add
> a "FOLL_" flag to make that more explicit, but for now, I've
> fixed up those sites.
>
> ---
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> For protection keys, we need to understand whether protections
> should be enforced in software or not. In general, we enforce
> protections when working on our own task, but not when on others.
> We call these "current" and "foreign" operations.
>
> This patch introduces a new get_user_pages() variant:
>
> get_user_pages_foreign()
>
> The plain get_user_pages() can no longer be used on mm/tasks
> other than 'current/current->mm', which is by far the most common
> way it is called. Using it makes a few of the call sites look a
> bit nicer.
>
> In other words, get_user_pages_foreign() is a replacement for
> when get_user_pages() is called on non-current tsk/mm.
>
> This also switches get_user_pages_(un)locked() over to be like
> get_user_pages() and not take a tsk/mm. There is no
> get_user_pages_foreign_(un)locked(). If someone wants that
> behavior they just have to use "__" variant and pass in
> FOLL_FOREIGN explicitly.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Cc: vbabka@suse.cz
> Cc: jack@suse.cz
> ---
>
After you fix up the nommu version of __get_user_pages_unlocked() below to match
the mmu one,
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> diff -puN mm/nommu.c~get_current_user_pages mm/nommu.c
> --- a/mm/nommu.c~get_current_user_pages 2016-01-19 15:48:31.794063748 -0800
> +++ b/mm/nommu.c 2016-01-19 15:48:31.835065603 -0800
[...]
> -long __get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm,
> - unsigned long start, unsigned long nr_pages,
> +long get_user_pages(unsigned long start, unsigned long nr_pages,
> + int write, int force, struct page **pages,
> + struct vm_area_struct **vmas)
> +{
> + return get_user_pages_foreign(current, current->mm, start, nr_pages,
> + write, force, pages, vmas);
> +}
> +EXPORT_SYMBOL(get_user_pages);
> +
> +long __get_user_pages_unlocked(unsigned long start, unsigned long nr_pages,
> int write, int force, struct page **pages,
> unsigned int gup_flags)
> {
> long ret;
> - down_read(&mm->mmap_sem);
> - ret = get_user_pages(tsk, mm, start, nr_pages, write, force,
> - pages, NULL);
> - up_read(&mm->mmap_sem);
> + down_read(¤t->mm->mmap_sem);
> + ret = get_user_pages(start, nr_pages, write, force, pages, NULL);
> + up_read(¤t->mm->mmap_sem);
> return ret;
> }
> EXPORT_SYMBOL(__get_user_pages_unlocked);
>
> -long get_user_pages_unlocked(struct task_struct *tsk, struct mm_struct *mm,
> - unsigned long start, unsigned long nr_pages,
> +long get_user_pages_unlocked(unsigned long start, unsigned long nr_pages,
> int write, int force, struct page **pages)
> {
> - return __get_user_pages_unlocked(tsk, mm, start, nr_pages, write,
> + return __get_user_pages_unlocked(start, nr_pages, write,
> force, pages, 0);
> }
> EXPORT_SYMBOL(get_user_pages_unlocked);
next prev parent reply other threads:[~2016-01-20 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:35 [PATCH] mm, gup: introduce concept of "foreign" get_user_pages() Dave Hansen
2016-01-20 17:56 ` Vlastimil Babka
2016-01-20 18:48 ` Dave Hansen
2016-01-20 19:30 ` Vlastimil Babka [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-22 18:02 Dave Hansen
2016-01-22 18:16 ` kbuild test robot
2016-01-22 21:31 ` Dave Hansen
2016-01-25 13:17 ` Srikar Dronamraju
2016-01-25 18:18 ` Oleg Nesterov
2016-01-27 11:30 ` Vlastimil Babka
2016-01-27 22:59 ` Dave Hansen
2016-01-15 18:11 Dave Hansen
2016-01-18 15:20 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569FE069.6080205@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).