linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andi Shyti <andi.shyti@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: Sangbeom Kim <sbkim73@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	Andi Shyti <andi@etezian.org>,
	Yadwinder Singh Brar <yadi.brar01@gmail.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init
Date: Thu, 21 Jan 2016 09:23:53 +0900	[thread overview]
Message-ID: <56A02519.4050207@samsung.com> (raw)
In-Reply-To: <1453284864-8082-3-git-send-email-andi.shyti@samsung.com>

On 20.01.2016 19:14, Andi Shyti wrote:
> The driver allocates three structures, s2mpsxx_clk_init, for
> three different clock types (s2mps11, s2mps13 and s2mps14). They
> are quite similar but they differ only by the name. Only one of
> these structures is used, while the others lie unused in the
> memory.
> 
> The clock's name, though, is not such a meaningful information
> and by assigning the same name to the initial data we can avoid
> over allocation. The common name chosen will be s2mps11,
> coherently with the device driver name, instead of the clock
> device.
> 
> Therefore, remove the structures associated to s2mps13 and
> s2mps14 and use only the one referred to s2mps11 for all kind of
> clocks.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  drivers/clk/clk-s2mps11.c | 51 +++++++----------------------------------------
>  1 file changed, 7 insertions(+), 44 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

  reply	other threads:[~2016-01-21  0:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 10:14 [PATCH v3 0/4] s2mps11 clock driver refactoring Andi Shyti
2016-01-20 10:14 ` [PATCH v3 1/4] clk: s2mps11: merge two for loops in one Andi Shyti
2016-01-21  0:20   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init Andi Shyti
2016-01-21  0:23   ` Krzysztof Kozlowski [this message]
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 3/4] clk: s2mps11: remove redundant static variables declaration Andi Shyti
2016-01-21  0:29   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-20 10:14 ` [PATCH v3 4/4] clk: s2mps11: remove redundant code Andi Shyti
2016-01-21  0:29   ` Krzysztof Kozlowski
2016-01-30  0:34   ` Stephen Boyd
2016-01-21  0:18 ` [PATCH v3 0/4] s2mps11 clock driver refactoring Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A02519.4050207@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=andi.shyti@samsung.com \
    --cc=andi@etezian.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sbkim73@samsung.com \
    --cc=sboyd@codeaurora.org \
    --cc=yadi.brar01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).