From: Jan Kiszka <jan.kiszka@siemens.com>
To: Kieran Bingham <kieran.bingham@linaro.org>
Cc: linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
peter.griffin@linaro.org, lee.jones@linaro.org
Subject: Re: [PATCH 4/5] scripts/gdb: Add mount point list command
Date: Sat, 23 Jan 2016 13:34:04 +0100 [thread overview]
Message-ID: <56A3733C.7090303@siemens.com> (raw)
In-Reply-To: <1453288550-4706-5-git-send-email-kieran.bingham@linaro.org>
On 2016-01-20 12:15, Kieran Bingham wrote:
> lx-mounts will identify current mount points based on the 'init_task'
> namespace by default, as we do not yet have a kernel thread list
> implementation to select the current running thread.
>
> Optionally, a user can specify a PID to list from that process'
> namespace
>
> This is somewhat limited vs the /proc/mounts file, as that calls into
> vfs hooks through the s_op functions to obtain extra information.
>
> Signed-off-by: Kieran Bingham <kieran.bingham@linaro.org>
> ---
>
>
> In this patch, I'm interested in your opinions on coding styles.
> Would you prefer to see the function helpers, (dentry_name, info_opts) where
> they are, or inside the command as class members? Or perhaps defined in utils?
>
> This also shows where I need to take constant information from the kernel.
> In this case, they are simple numerical bitflags, and unlikely to change but
> I didn't want to duplicate their values.
>
>
> scripts/gdb/linux/constants.py.in | 21 ++++++++
> scripts/gdb/linux/proc.py | 110 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 131 insertions(+)
>
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index d84084ac945b..739a15d2e984 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -12,7 +12,11 @@
> *
> */
>
> +#include <linux/fs.h>
> +#include <linux/mount.h>
> +
> /* We need to stringify expanded macros so that they can be parsed */
> #define STRING(x) #x
> #define XSTRING(x) STRING(x)
>
This hunk is malformed, indicating that 4 lines are added while there
are actually only 3 new ones. Could you check what went wrong? I'm
applying it manually for now.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2016-01-23 12:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:15 [RFC PATCH 0/5] scripts/gdb: Linux awareness debug commands Kieran Bingham
2016-01-20 11:15 ` [PATCH 1/5] scripts/gdb: Provide linux constants Kieran Bingham
2016-01-23 15:05 ` Jan Kiszka
2016-01-24 0:11 ` Kieran Bingham
2016-01-20 11:15 ` [PATCH 2/5] scripts/gdb: Provide a kernel list item generator Kieran Bingham
2016-01-23 15:08 ` Jan Kiszka
2016-01-24 0:15 ` Kieran Bingham
2016-01-20 11:15 ` [PATCH 3/5] scripts/gdb: Add io resource readers Kieran Bingham
2016-01-23 15:12 ` Jan Kiszka
2016-01-24 0:17 ` Kieran Bingham
2016-01-20 11:15 ` [PATCH 4/5] scripts/gdb: Add mount point list command Kieran Bingham
2016-01-20 11:42 ` Jan Kiszka
2016-01-20 11:51 ` Kieran Bingham
2016-01-20 12:08 ` Jan Kiszka
2016-01-23 12:34 ` Jan Kiszka [this message]
2016-01-23 15:27 ` Jan Kiszka
2016-01-24 0:24 ` Kieran Bingham
2016-01-20 11:15 ` [PATCH 5/5] scripts/gdb: Add meminfo command Kieran Bingham
2016-01-23 15:21 ` Jan Kiszka
2016-01-24 0:30 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A3733C.7090303@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kieran.bingham@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).