From: Jonathan Cameron <jic23@kernel.org>
To: Alexander Koch <mail@alexanderkoch.net>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
mhornung.linux@gmail.com, dannenberg@ti.com, balbi@ti.com,
fengguang.wu@intel.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring
Date: Sun, 24 Jan 2016 15:02:06 +0000 [thread overview]
Message-ID: <56A4E76E.6060309@kernel.org> (raw)
In-Reply-To: <1452960878-1727-3-git-send-email-mail@alexanderkoch.net>
On 16/01/16 16:14, Alexander Koch wrote:
> Change variable type of struct opt3001 members 'ok_to_ignore_lock' and
> 'result_ready' uint16-bitfield of length one to bool.
>
> They are used as bool, let the compiler do the optimization.
>
> Signed-off-by: Alexander Koch <mail@alexanderkoch.net>
> Signed-off-by: Michael Hornung <mhornung.linux@gmail.com>
I find it hard to care much about this one, but consistency is
always good and the bitfield never made much sense in here.
Applied to the togreg branch of iio.git - pushed out as testing... etc.
Thanks,
Jonathan
> ---
> drivers/iio/light/opt3001.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> index aefbd79..b05c484 100644
> --- a/drivers/iio/light/opt3001.c
> +++ b/drivers/iio/light/opt3001.c
> @@ -79,8 +79,8 @@ struct opt3001 {
> struct device *dev;
>
> struct mutex lock;
> - u16 ok_to_ignore_lock:1;
> - u16 result_ready:1;
> + bool ok_to_ignore_lock;
> + bool result_ready;
> wait_queue_head_t result_ready_queue;
> u16 result;
>
>
next prev parent reply other threads:[~2016-01-24 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 16:14 [PATCH v2 0/3] iio: light: opt3001: Enable operation w/o IRQ Alexander Koch
2016-01-16 16:14 ` [PATCH v2 1/3] iio: light: opt3001: extract int. time constants Alexander Koch
2016-01-24 15:01 ` Jonathan Cameron
2016-01-29 17:59 ` Andreas Dannenberg
2016-01-16 16:14 ` [PATCH v2 2/3] iio: light: opt3001: trivial type refactoring Alexander Koch
2016-01-24 15:02 ` Jonathan Cameron [this message]
2016-01-29 18:00 ` Andreas Dannenberg
2016-01-16 16:14 ` [PATCH v2 3/3] iio: light: opt3001: enable operation w/o IRQ Alexander Koch
2016-01-18 17:07 ` Martin Kepplinger
2016-01-23 18:55 ` Alexander Koch
2016-01-24 14:55 ` Jonathan Cameron
2016-01-24 15:07 ` Jonathan Cameron
2016-01-29 18:01 ` Andreas Dannenberg
2016-01-30 16:27 ` Jonathan Cameron
2016-01-29 18:05 ` [PATCH v2 0/3] iio: light: opt3001: Enable " Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A4E76E.6060309@kernel.org \
--to=jic23@kernel.org \
--cc=balbi@ti.com \
--cc=dannenberg@ti.com \
--cc=fengguang.wu@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=mhornung.linux@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).