From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754915AbcAYD2m (ORCPT ); Sun, 24 Jan 2016 22:28:42 -0500 Received: from e28smtp02.in.ibm.com ([125.16.236.2]:47876 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbcAYD2j (ORCPT ); Sun, 24 Jan 2016 22:28:39 -0500 X-IBM-Helo: d28relay04.in.ibm.com X-IBM-MailFrom: maddy@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH V10 2/4] perf/powerpc: add support for sampling intr machine state To: Michael Ellerman , Anju T References: <1452508104-16507-1-git-send-email-anju@linux.vnet.ibm.com> <1452508104-16507-3-git-send-email-anju@linux.vnet.ibm.com> <1453286426.14751.19.camel@ellerman.id.au> Cc: hemant@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, acme@redhat.com, dsahern@gmail.com, naveen.n.rao@linux.vnet.ibm.com, sukadev@linux.vnet.ibm.com, jolsa@redhat.com, khandual@linux.vnet.ibm.com From: Madhavan Srinivasan Message-ID: <56A59651.6010903@linux.vnet.ibm.com> Date: Mon, 25 Jan 2016 08:58:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453286426.14751.19.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 16012503-0005-0000-0000-00000A0B58B1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 20 January 2016 04:10 PM, Michael Ellerman wrote: > On Mon, 2016-01-11 at 15:58 +0530, Anju T wrote: >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig >> index 9a7057e..c4ce60d 100644 >> --- a/arch/powerpc/Kconfig >> +++ b/arch/powerpc/Kconfig >> @@ -119,6 +119,7 @@ config PPC >> select GENERIC_ATOMIC64 if PPC32 >> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE >> select HAVE_PERF_EVENTS >> + select HAVE_PERF_REGS >> select HAVE_REGS_AND_STACK_ACCESS_API >> select HAVE_HW_BREAKPOINT if PERF_EVENTS && PPC_BOOK3S_64 >> select ARCH_WANT_IPC_PARSE_VERSION >> diff --git a/arch/powerpc/perf/perf_regs.c b/arch/powerpc/perf/perf_regs.c >> new file mode 100644 >> index 0000000..d32581763 >> --- /dev/null >> +++ b/arch/powerpc/perf/perf_regs.c > ... >> + >> +u64 perf_reg_abi(struct task_struct *task) >> +{ >> + return PERF_SAMPLE_REGS_ABI_64; > What is this value used for exactly? > > It seems like on 32-bit kernels we should be returning PERF_SAMPLE_REGS_ABI_32. Yes. you are right. But even in 64bit kernel, based on the application we need to return 32 to 64 abi. Damn my bad. missed 32bit part all together. Maddy > >> +} >> + >> +void perf_get_regs_user(struct perf_regs *regs_user, >> + struct pt_regs *regs, >> + struct pt_regs *regs_user_copy) >> +{ >> + regs_user->regs = task_pt_regs(current); >> + regs_user->abi = perf_reg_abi(current); >> +} > cheers > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev