From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbcAZXfB (ORCPT ); Tue, 26 Jan 2016 18:35:01 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34379 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbcAZXe7 (ORCPT ); Tue, 26 Jan 2016 18:34:59 -0500 Message-ID: <56A8026F.8090001@gmail.com> Date: Tue, 26 Jan 2016 15:34:07 -0800 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Richard Weinberger , linux-kernel@vger.kernel.org CC: user-mode-linux-devel@lists.sourceforge.net, Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Alexandre Belloni , Moritz Fischer , Jun Nie , linux-pm@vger.kernel.org Subject: Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs References: <1453760661-1444-1-git-send-email-richard@nod.at> <1453760661-1444-2-git-send-email-richard@nod.at> In-Reply-To: <1453760661-1444-2-git-send-email-richard@nod.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/16 14:24, Richard Weinberger wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger > --- > drivers/power/reset/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 1131cf7..0a6408a 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE > config POWER_RESET_SYSCON > bool "Generic SYSCON regmap reset driver" > depends on OF > + depends on HAS_IOMEM > select MFD_SYSCON Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself does not issue I/O accesses per-se, but does use helpers from regmap, which in turn do it. > help > Reboot support for generic SYSCON mapped register reset. > @@ -155,6 +156,7 @@ config POWER_RESET_SYSCON > config POWER_RESET_SYSCON_POWEROFF > bool "Generic SYSCON regmap poweroff driver" > depends on OF > + depends on HAS_IOMEM > select MFD_SYSCON Likewise. -- Florian