From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexios Zavras <alexios.zavras@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Nikolaus Schaller <hns@goldelico.com>,
Rob Herring <robh+dt@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/2] net: wireless: ti: wl1251: sdio: remove ti,power-gpio
Date: Sun, 24 Nov 2019 11:47:59 +0100 [thread overview]
Message-ID: <56A8FB98-51B6-4CAC-9743-0A86DFE09CA8@goldelico.com> (raw)
In-Reply-To: <e1f18e0f1401a0d8b07ccb176732a2e3f3a5732a.1574591746.git.hns@goldelico.com>
> Am 24.11.2019 um 11:35 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>
> Remove handling of this property from code.
> Note that wl->power_gpio is still needed in
> the header file for SPI mode (N900).
>
> Suggested by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/net/wireless/ti/wl1251/sdio.c | 30 ---------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c
> index df0c20a555e3..82446196f9a8 100644
> --- a/drivers/net/wireless/ti/wl1251/sdio.c
> +++ b/drivers/net/wireless/ti/wl1251/sdio.c
> @@ -15,9 +15,7 @@
> #include <linux/wl12xx.h>
> #include <linux/irq.h>
> #include <linux/pm_runtime.h>
> -#include <linux/gpio.h>
> #include <linux/of.h>
> -#include <linux/of_gpio.h>
> #include <linux/of_irq.h>
>
> #include "wl1251.h"
> @@ -162,15 +160,6 @@ static int wl1251_sdio_set_power(struct wl1251 *wl, bool enable)
> printk("%s %d\n", __func__, enable);
>
> if (enable) {
> - /*
> - * Power is controlled by runtime PM, but we still call board
> - * callback in case it wants to do any additional setup,
> - * for example enabling clock buffer for the module.
> - */
> - if (gpio_is_valid(wl->power_gpio))
> - gpio_set_value(wl->power_gpio, true);
> -
> -
> ret = pm_runtime_get_sync(&func->dev);
> if (ret < 0) {
> pm_runtime_put_sync(&func->dev);
> @@ -188,9 +177,6 @@ printk("%s %d\n", __func__, enable);
> ret = pm_runtime_put_sync(&func->dev);
> if (ret < 0)
> goto out;
> -
> - if (gpio_is_valid(wl->power_gpio))
> - gpio_set_value(wl->power_gpio, false);
> }
>
> out:
> @@ -245,27 +231,11 @@ printk("%s: of=%pOFcC\n", __func__, np);
>
> wl1251_board_data = wl1251_get_platform_data();
> if (!IS_ERR(wl1251_board_data)) {
> - wl->power_gpio = wl1251_board_data->power_gpio;
> wl->irq = wl1251_board_data->irq;
> wl->use_eeprom = wl1251_board_data->use_eeprom;
> } else if (np) {
> wl->use_eeprom =of_property_read_bool(np, "ti,wl1251-has-eeprom");
> - wl->power_gpio = of_get_named_gpio(np, "ti,power-gpio", 0);
> wl->irq = of_irq_get(np, 0);
> -
> - if (wl->power_gpio == -EPROBE_DEFER || wl->irq == -EPROBE_DEFER) {
^^^ spotted a bug myself... wl->irq check must not be removed.
Noted for v2.
> - ret = -EPROBE_DEFER;
> - goto disable;
> - }
> - }
> -
> - if (gpio_is_valid(wl->power_gpio)) {
> - ret = devm_gpio_request(&func->dev, wl->power_gpio,
> - "wl1251 power");
> - if (ret) {
> - wl1251_error("Failed to request gpio: %d\n", ret);
> - goto disable;
> - }
> }
>
> if (wl->irq) {
> --
> 2.23.0
>
next prev parent reply other threads:[~2019-11-24 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 10:35 [PATCH 0/2] net: wireless: ti: wl1251: sdio: remove ti,power-gpio H. Nikolaus Schaller
2019-11-24 10:35 ` [PATCH 1/2] DTS: bindings: wl1251: mark ti,power-gpio as optional H. Nikolaus Schaller
2019-12-05 16:51 ` Rob Herring
2019-11-24 10:35 ` [PATCH 2/2] net: wireless: ti: wl1251: sdio: remove ti,power-gpio H. Nikolaus Schaller
2019-11-24 10:47 ` H. Nikolaus Schaller [this message]
2019-11-26 15:53 ` Kalle Valo
[not found] ` <0101016ea86aaa23-4980977b-7718-4ce8-9089-ae7936f60eee-000000@us-west-2.amazonses.com>
2019-11-26 16:35 ` H. Nikolaus Schaller
2019-11-26 15:51 ` [PATCH 0/2] " Kalle Valo
[not found] ` <0101016ea86910ca-f8c93455-c4de-4906-a10a-bba6be6ff35a-000000@us-west-2.amazonses.com>
2019-11-26 16:34 ` H. Nikolaus Schaller
[not found] ` <0101016ea8691109-5beadf07-b3ba-4d31-a516-c7f3015f2316-000000@us-west-2.amazonses.com>
2019-11-26 17:42 ` [Letux-kernel] [PATCH 0/2] net: wireless: ti: wl1251: sdio: remove ti, power-gpio Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8FB98-51B6-4CAC-9743-0A86DFE09CA8@goldelico.com \
--to=hns@goldelico.com \
--cc=alexios.zavras@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pyra-handheld.com \
--cc=kvalo@codeaurora.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).