From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964936AbcA1ILN (ORCPT ); Thu, 28 Jan 2016 03:11:13 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:51673 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933871AbcA1ILK (ORCPT ); Thu, 28 Jan 2016 03:11:10 -0500 X-AuditID: cbfec7f5-f79b16d000005389-e1-56a9cd1cb71f Subject: Re: [PATCH 12/19] ARM: dts: exynos: replace legacy *,wakeup property with wakeup-source To: Sudeep Holla , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <1445422216-29375-1-git-send-email-sudeep.holla@arm.com> <1445422216-29375-13-git-send-email-sudeep.holla@arm.com> <5671F88F.7050802@samsung.com> Cc: Kukjin Kim , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56A9CD1A.8010800@samsung.com> Date: Thu, 28 Jan 2016 17:11:06 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <5671F88F.7050802@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xa7oyZ1eGGfRM4rCYf+Qcq8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72OyWH5qB4sDu8eaeWsYPTat6mTz2Lyk3qNvyypGj8+b5AJY o7hsUlJzMstSi/TtErgyzk6ayVJwW75i1tpPzA2MfyS6GDk5JARMJFou32ODsMUkLtxbD2YL CSxllNh+tbaLkQvIfsoosXDaV9YuRg4OYYEkiakn7UDiIgKdjBLnGu6wQxQtZJQ43r2bBaSI WcBF4tGjVJBBbALGEpuXL4FaICfR2z2JBcTmFdCSOPC7jQnEZhFQlZi5oR2sRlQgQuJwZxc7 RI2gxI/J98DqOQW0JTZe/sYMMV5P4v5FLZAws4C8xOY1b5knMArOQtIxC6FqFpKqBYzMqxhF U0uTC4qT0nON9IoTc4tL89L1kvNzNzFCgv7rDsalx6wOMQpwMCrx8DJErQwTYk0sK67MPcQo wcGsJMKrWA0U4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dU A+MmXp8bznoqraWP/b/cfjxjsX6pmN7T9Y/PiN6vbniof1DWcfmStB5nF6GFrqd+n1M1UF/5 PidZhnVSyj2Bp4ae0ns4Nl5aFnY8buNUkZTyBqV9OUHtQU0bEh8uWaX98Q4H0+GbjcWza7++ 3DizOGhh3jvx67UHfRZdXKd58POnt+d2fb40eUalEktxRqKhFnNRcSIApa8tSHYCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.12.2015 08:49, Krzysztof Kozlowski wrote: > On 21.10.2015 19:10, Sudeep Holla wrote: >> Though the keyboard and other driver will continue to support the legacy >> "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the >> wakeup source, "wakeup-source" is the new standard binding. >> >> This patch replaces all the legacy wakeup properties with the unified >> "wakeup-source" property in order to avoid any futher copy-paste >> duplication. >> >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski >> Cc: linux-samsung-soc@vger.kernel.org >> Signed-off-by: Sudeep Holla >> --- >> arch/arm/boot/dts/exynos3250-monk.dts | 6 +++--- >> arch/arm/boot/dts/exynos3250-rinato.dts | 6 +++--- >> arch/arm/boot/dts/exynos4210-origen.dts | 10 +++++----- >> arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +- >> arch/arm/boot/dts/exynos4210-trats.dts | 2 +- >> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++-- >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +- >> arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +- >> arch/arm/boot/dts/exynos4412-origen.dts | 2 +- >> arch/arm/boot/dts/exynos4412-smdk4412.dts | 2 +- >> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++-- >> arch/arm/boot/dts/exynos5250-arndale.dts | 12 ++++++------ >> arch/arm/boot/dts/exynos5250-snow.dts | 4 ++-- >> arch/arm/boot/dts/exynos5250-spring.dts | 4 ++-- >> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 ++-- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++-- >> 17 files changed, 36 insertions(+), 36 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts >> index 540a0adf2be6..b77ea2163a0a 100644 >> --- a/arch/arm/boot/dts/exynos3250-monk.dts >> +++ b/arch/arm/boot/dts/exynos3250-monk.dts >> @@ -43,7 +43,7 @@ >> linux,code = ; >> label = "power key"; >> debounce-interval = <10>; >> - gpio-key,wakeup; >> + wakeup-source; >> }; >> }; >> >> @@ -67,7 +67,7 @@ >> interrupt-parent = <&gpx1>; >> interrupts = <5 0>; >> reg = <0x25>; >> - wakeup; >> + wakeup-source; >> >> muic: max77836-muic { >> compatible = "maxim,max77836-muic"; >> @@ -184,7 +184,7 @@ >> interrupt-parent = <&gpx0>; >> interrupts = <7 0>; >> reg = <0x66>; >> - wakeup; >> + wakeup-source; >> >> s2mps14_osc: clocks { >> compatible = "samsung,s2mps14-clk"; >> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts >> index 41a5fafb9aa9..7acd11d2d957 100644 >> --- a/arch/arm/boot/dts/exynos3250-rinato.dts >> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts >> @@ -43,7 +43,7 @@ >> linux,code = ; >> label = "power key"; >> debounce-interval = <10>; >> - gpio-key,wakeup; >> + wakeup-source; >> }; >> }; >> >> @@ -58,7 +58,7 @@ >> interrupt-parent = <&gpx1>; >> interrupts = <5 0>; >> reg = <0x25>; >> - wakeup; >> + wakeup-source; >> >> muic: max77836-muic { >> compatible = "maxim,max77836-muic"; >> @@ -245,7 +245,7 @@ >> interrupt-parent = <&gpx0>; >> interrupts = <7 0>; >> reg = <0x66>; >> - wakeup; >> + wakeup-source; > > I think here and in Monk board these four "wakeup" properties are bogus, > not parsed by driver. Instead wakeup is always initialized to true. > > Anyway fixing this is not part of this patch but instead this should be > fixed in separate commit. Here everything looks good: > > Reviewed-by: Krzysztof Kozlowski This patch does not apply. Can you rebase it on linux-next or my next/dt branch (git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git)? I applied the 16/19 (s5pv210). Best regards, Krzysztof