From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932623AbcA2Pw0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 10:52:26 -0500
Received: from exsmtp01.microchip.com ([198.175.253.37]:41339 "EHLO
	email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S932179AbcA2PwZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 10:52:25 -0500
Subject: Re: [PATCH 03/15] mips: use of_platform_default_populate() to
 populate default bus
To: Kefeng Wang <wangkefeng.wang@huawei.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com>
 <1453868872-26300-4-git-send-email-wangkefeng.wang@huawei.com>
CC: Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
        Russell King <linux@arm.linux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        <guohanjun@huawei.com>, Ralf Baechle <ralf@linux-mips.org>
From: Joshua Henderson <joshua.henderson@microchip.com>
Message-ID: <56AB8CA4.7070803@microchip.com>
Date: Fri, 29 Jan 2016 09:00:36 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1453868872-26300-4-git-send-email-wangkefeng.wang@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/26/2016 09:27 PM, Kefeng Wang wrote:
> Use helper of_platform_default_populate() in linux/of_platform
> when possible, instead of calling of_platform_populate() with
> the default match table.
> 
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  arch/mips/ath79/setup.c           | 2 +-
>  arch/mips/jz4740/setup.c          | 2 +-
>  arch/mips/mti-sead3/sead3-setup.c | 2 +-
>  arch/mips/pic32/pic32mzda/init.c  | 3 +--
>  arch/mips/pistachio/init.c        | 2 +-
>  arch/mips/xilfpga/init.c          | 2 +-
>  6 files changed, 6 insertions(+), 7 deletions(-)
> 

[...]

> diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
> index 775ff90..77ecf32 100644
> --- a/arch/mips/pic32/pic32mzda/init.c
> +++ b/arch/mips/pic32/pic32mzda/init.c
> @@ -147,8 +147,7 @@ static int __init plat_of_setup(void)
>  		panic("Device tree not present");
>  
>  	pic32_of_prepare_platform_data(pic32_auxdata_lookup);
> -	if (of_platform_populate(NULL, of_default_bus_match_table,
> -				 pic32_auxdata_lookup, NULL))
> +	if (of_platform_default_populate(NULL, pic32_auxdata_lookup, NULL))
>  		panic("Failed to populate DT");
>  
>  	return 0;

I'll one-up just compile-testing for this.

Tested-by: Joshua Henderson <joshua.henderson@microchip.com>

[...]