From: Lars-Peter Clausen <lars@metafoo.de>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Jonathan Cameron <jic23@kernel.org>,
Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net,
Bhumika Goyal <bhumirks@gmail.com>
Subject: Re: [PATCH 1/2] staging:iio:adc:added space around '-'
Date: Sat, 30 Jan 2016 16:15:38 +0100 [thread overview]
Message-ID: <56ACD39A.1040003@metafoo.de> (raw)
In-Reply-To: <20160130151213.GC13219@mwanda>
On 01/30/2016 04:12 PM, Dan Carpenter wrote:
> We could make checkpatch.pl not complain if the line says checkpatch: on
> it. It would look like this.
>
> - in_voltage-voltage_thresh_low_value,
> + in_voltage-voltage_thresh_low_value, /* checkpatch: not math */
>
> I suppose I could have made the explanation longer since the it won't
> complain about the 80 character limit... What do you guys think?
We could add it as a temporary way to silence the checker. But it feels a
bit ugly, there is really no reason why this shouldn't be a string, other
than that the current device attr macros don't support that.
- Lars
next prev parent reply other threads:[~2016-01-30 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:42 [PATCH 0/2]Staging:iio:adc:add space around '-' Bhumika Goyal
2016-01-15 19:42 ` [PATCH 1/2] staging:iio:adc:added " Bhumika Goyal
2016-01-15 20:15 ` Lars-Peter Clausen
2016-01-20 14:21 ` Dan Carpenter
2016-01-24 16:36 ` Jonathan Cameron
2016-01-24 17:14 ` Lars-Peter Clausen
2016-01-30 14:12 ` Jonathan Cameron
2016-01-30 15:12 ` Dan Carpenter
2016-01-30 15:15 ` Lars-Peter Clausen [this message]
2016-01-30 17:02 ` Joe Perches
2016-01-15 19:42 ` [PATCH 2/2] staging:iio:adc:add " Bhumika Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ACD39A.1040003@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=bhumirks@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).