From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751495AbcBLO3m (ORCPT ); Fri, 12 Feb 2016 09:29:42 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:50669 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbcBLO3j (ORCPT ); Fri, 12 Feb 2016 09:29:39 -0500 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: manoj@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Reply-To: manoj@linux.vnet.ibm.com Subject: Re: [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums References: <1455154348-3226-1-git-send-email-tyreld@linux.vnet.ibm.com> <1455154348-3226-2-git-send-email-tyreld@linux.vnet.ibm.com> To: Tyrel Datwyler , james.bottomley@hansenpartnership.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, jthumshirn@suse.de From: Manoj Kumar Organization: IBM Message-ID: <56BDEC53.3010400@linux.vnet.ibm.com> Date: Fri, 12 Feb 2016 08:29:39 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455154348-3226-2-git-send-email-tyreld@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021214-8236-0000-0000-0000160F40F4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Manoj Kumar --- Manoj Kumar On 2/10/2016 7:32 PM, Tyrel Datwyler wrote: > The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are > off by one. They are currently defined as 0x06 and 0x07 respetively. > These values are defined in PAPR correctly as 0x05 and 0x06. This > inconsistency has gone unnoticed as neither enum is currently used. > The possible future support of PING messages between the VIOS and > client adapter relies on VIOSRP_INLINE_FORMAT crq messages. > Corrected these enum values to match PAPR definitions. > > Signed-off-by: Tyrel Datwyler > Reviewed-by: Johannes Thumshirn > --- > drivers/scsi/ibmvscsi/viosrp.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/viosrp.h b/drivers/scsi/ibmvscsi/viosrp.h > index 1162430..d1044e9 100644 > --- a/drivers/scsi/ibmvscsi/viosrp.h > +++ b/drivers/scsi/ibmvscsi/viosrp.h > @@ -56,8 +56,8 @@ enum viosrp_crq_formats { > VIOSRP_MAD_FORMAT = 0x02, > VIOSRP_OS400_FORMAT = 0x03, > VIOSRP_AIX_FORMAT = 0x04, > - VIOSRP_LINUX_FORMAT = 0x06, > - VIOSRP_INLINE_FORMAT = 0x07 > + VIOSRP_LINUX_FORMAT = 0x05, > + VIOSRP_INLINE_FORMAT = 0x06 > }; > > enum viosrp_crq_status { >