From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Rob Herring <robh@kernel.org>, Joao Pinto <Joao.Pinto@synopsys.com>
Cc: <vinholikatti@gmail.com>, <julian.calaby@gmail.com>,
<akinobu.mita@gmail.com>, <hch@infradead.org>, <arnd@arndb.de>,
<mark.rutland@arm.com>, <gbroner@codeaurora.org>,
<subhashj@codeaurora.org>, <CARLOS.PALMINHA@synopsys.com>,
<ijc+devicetree@hellion.org.uk>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller
Date: Fri, 12 Feb 2016 17:52:08 +0000 [thread overview]
Message-ID: <56BE1BC8.5020604@synopsys.com> (raw)
In-Reply-To: <20160212163636.GA31045@rob-hp-laptop>
Hi Rob,
On 2/12/2016 4:36 PM, Rob Herring wrote:
> On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote:
>> +Required properties:
>> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1"
>> + or "snps,ufshcd-2.0")
>
> History has taught us this needs to have a vendor specific compatible
> string as well. Don't necessarily have to define it now, but just state
> a vendor string is needed too.
The compatibility string already as the "snps" which is the acronym for Synopsys
which is the HW Controller vendor. Isn't this enough?
>
>> +- reg : <registers mapping>
>> +- interrupts : <interrupt mapping for UFS host controller IRQ>
>> +
>> +Example:
>> + ufs@0xd0000000 {
>> + compatible = "snps,ufshcd-2.0";
>> + reg = < 0xd0000000 0x10000 >;
>> + interrupts = < 24 >;
>> + };
Thanks,
Joao
next prev parent reply other threads:[~2016-02-12 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 12:13 [PATCH v7 0/3] add support for DWC UFS Controller Joao Pinto
2016-02-11 12:13 ` [PATCH v7 1/3] fixed typo in ufshcd-pltfrm Joao Pinto
2016-02-11 12:13 ` [PATCH v7 2/3] added UFS 2.0 capabilities Joao Pinto
2016-02-11 12:13 ` [PATCH v7 3/3] add support for DWC UFS Host Controller Joao Pinto
2016-02-12 16:36 ` Rob Herring
2016-02-12 17:52 ` Joao Pinto [this message]
2016-02-12 19:36 ` Rob Herring
2016-02-13 13:27 ` Akinobu Mita
2016-02-15 11:16 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE1BC8.5020604@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).