From: "Kim, Milo" <milo.kim@ti.com>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Javier Martinez Canillas" <javier@dowhile0.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support
Date: Mon, 15 Feb 2016 08:31:02 +0900 [thread overview]
Message-ID: <56C10E36.1030808@ti.com> (raw)
In-Reply-To: <1455301532.2760.1.camel@collins>
On 2/13/2016 3:25 AM, Paul Kocialkowski wrote:
>>> > >+
>>> > >+ /* Always set enable GPIO high. */
>>> > >+ ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN");
>>> > >+ if (ret) {
>>> > >+ dev_err(lp->dev, "gpio request err: %d\n", ret);
>>> > >+ return ret;
>>> > >+ }
>>> > >+
>>> > >+ /* Each chip has a different enable delay. */
>>> > >+ if (lp->chipid == LP8720)
>>> > >+ usleep_range(LP8720_ENABLE_DELAY, 1.5 * LP8720_ENABLE_DELAY);
>>> > >+ else
>>> > >+ usleep_range(LP8725_ENABLE_DELAY, 1.5 * LP8725_ENABLE_DELAY);
>>> > >+
>>> > >+ return 0;
>>> > >+}
>>> > >+
>>> > > static int lp872x_config(struct lp872x *lp)
>>> > > {
>>> > > struct lp872x_platform_data *pdata = lp->pdata;
>>> > >@@ -875,6 +903,8 @@ static struct lp872x_platform_data
>>> > > of_property_read_u8(np, "ti,dvs-state", &dvs_state);
>>> > > pdata->dvs->init_state = dvs_state ? DVS_HIGH : DVS_LOW;
>>> > >
>>> > >+ pdata->enable_gpio = of_get_named_gpio(np, "enable-gpios", 0);
>> >
>> >Please move this code to lp872x_populate_pdata_from_dt().
> This already adds it in lp872x_populate_pdata_from_dt (see the context
> around the insertion).
Ah, sorry. Your patch is correct.
> I don't know why the diff makes it seem like it's added in
> lp872x_config. It's really not.
I think it was from a line break of lp872x_populate_pdata_from_dt().
Let me add my ACK to this patch. Thank you.
Best regards,
Milo
next prev parent reply other threads:[~2016-02-14 23:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 18:42 [PATCH v2 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski
2016-02-05 18:42 ` [PATCH v2 1/4] regulator: lp872x: Remove warning about invalid DVS GPIO Paul Kocialkowski
2016-02-12 0:14 ` Kim, Milo
2016-02-05 18:42 ` [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski
2016-02-08 19:50 ` Rob Herring
2016-02-12 0:14 ` Kim, Milo
2016-02-12 18:25 ` Paul Kocialkowski
2016-02-14 23:31 ` Kim, Milo [this message]
2016-02-14 23:37 ` Kim, Milo
2016-02-05 18:42 ` [PATCH v2 3/4] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski
2016-02-05 19:39 ` Paul Kocialkowski
2016-02-07 15:23 ` Paul Kocialkowski
2016-02-05 18:42 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C10E36.1030808@ti.com \
--to=milo.kim@ti.com \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@dowhile0.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).