From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933912AbcBQJqp (ORCPT ); Wed, 17 Feb 2016 04:46:45 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8111 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933487AbcBQJqj convert rfc822-to-8bit (ORCPT ); Wed, 17 Feb 2016 04:46:39 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 17 Feb 2016 01:46:46 -0800 Message-ID: <56C4417D.2030409@nvidia.com> Date: Wed, 17 Feb 2016 17:46:37 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Rob Herring CC: Sascha Hauer , Thierry Reding , Zhang Rui , , Stephen Warren , "Mikko Perttunen" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm References: <1454057260-16412-1-git-send-email-wni@nvidia.com> <56C17AFD.8050203@nvidia.com> In-Reply-To: <56C17AFD.8050203@nvidia.com> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL101.nvidia.com (10.18.16.10) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rob On 2016年02月15日 15:15, Wei Ni wrote: > Hi, Rob > > On 2016年02月12日 22:42, Rob Herring wrote: >> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni wrote: >>> Add hw-trips sub-node for soctherm, which is >>> used to describe the hardware trip points for >>> each soctherm sensors. >> >> I still don't understand why you are doing something custom here. >> What's wrong with what is defined in: >> >> Documentation/devicetree/bindings/thermal/thermal.txt I think it's better to add a .set_trip_temp for of-thermal's thermal_zone_of_device_ops{}, so that we can set trip points on hardware. I'm preparing patches, and will send out next version. Thanks for your comments. > > In current thermal framework, it support to set trip points for the thermal > zones, but this trip point is handled by SW, doesn't have callbacks to program > the hardware. > There had patches: > [PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points, > http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html, > which can support to program hardware to set trip points, but it seems this > series didn't be taken. > So I add this hw-trip-points sub-node for soctherm. > > Hi, Sascha Hauer > > Thanks. > Wei. > >> >> Rob >>